RESOLVED FIXED 66113
[CFNetwork] willCacheResponse() leaks CFCachedURLResponseRef if delegate changes CacheStoragePolicy 
https://bugs.webkit.org/show_bug.cgi?id=66113
Summary [CFNetwork] willCacheResponse() leaks CFCachedURLResponseRef if delegate chan...
David Kilzer (:ddkilzer)
Reported 2011-08-11 16:12:13 PDT
* SUMMARY If the delegate callback changes the CacheStoragePolicy in willCacheResponse() in ResourceHandleCFNet.cpp, the cachedResponse object is returned as +2 retained. The contract for this method is to return a +1 retained object. This regressed in ToT WebKit r23462. <http://trac.webkit.org/changeset/23462>
Attachments
Patch v1 (2.33 KB, patch)
2011-08-11 16:28 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2011-08-11 16:28:39 PDT
Created attachment 103700 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2011-08-11 16:30:32 PDT
<rdar://problem/9941235>
Joseph Pecoraro
Comment 3 2011-08-11 16:51:41 PDT
Comment on attachment 103700 [details] Patch v1 Great find!
WebKit Review Bot
Comment 4 2011-08-11 17:52:42 PDT
Comment on attachment 103700 [details] Patch v1 Clearing flags on attachment: 103700 Committed r92897: <http://trac.webkit.org/changeset/92897>
WebKit Review Bot
Comment 5 2011-08-11 17:52:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.