Bug 66112 - Initialize threading before running any tests
Summary: Initialize threading before running any tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-11 16:07 PDT by Anders Carlsson
Modified: 2011-08-11 16:18 PDT (History)
0 users

See Also:

Attachments
Patch (1.15 KB, patch)
2011-08-11 16:08 PDT, Anders Carlsson 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-08-11 16:07:04 PDT 
Initialize threading before running any tests
Comment 1 Anders Carlsson 2011-08-11 16:08:08 PDT 
Created attachment 103695 [details]
Patch
Comment 2 Anders Carlsson 2011-08-11 16:14:25 PDT 
This is to fix an assertion seen on the bots when running tests, due to threading not being initialized:


ASSERTION FAILED: m_key != PTHREAD_KEYS_MAX
/Volumes/Big/slave/snowleopard-intel-debug/build/Source/JavaScriptCore/wtf/ThreadIdentifierDataPthreads.cpp(60) : static WTF::ThreadIdentifier WTF::ThreadIdentifierData::identifier()
1   WTF::ThreadIdentifierData::identifier()
2   WTF::currentThread()
3   WTF::ThreadRestrictionVerifier::setShared(bool)
4   WTF::RefCountedBase::ref()
5   WKRetain
6   WebKit::WKRetainPtr<OpaqueWKString const*>::WKRetainPtr(WebKit::WKRetainPtr<OpaqueWKString const*> const&)
7   testing::AssertionResult TestWebKitAPI::Util::assertWKStringEqual<char const*, WebKit::WKRetainPtr<OpaqueWKString const*> >(char const*, char const*, char const*, WebKit::WKRetainPtr<OpaqueWKString const*>)
8   TestWebKitAPI::WebKit2_WKPreferencesDefaults_Test::TestBody()
9   testing::Test::Run()
10  testing::internal::TestInfoImpl::Run()
11  testing::TestCase::Run()
12  testing::internal::UnitTestImpl::RunAllTests()
13  testing::UnitTest::Run()
14  TestWebKitAPI::TestsController::run(int, char**)
15  main
16  start
Comment 3 Anders Carlsson 2011-08-11 16:18:28 PDT 
Committed r92887: <http://trac.webkit.org/changeset/92887>