Bug 66091 - Share code between isStyleSpanOrSpanWithOnlyStyleAttribute, isUnstyledStyleSpan, isSpanWithoutAttributesOrUnstyleStyleSpan and replaceWithSpanOrRemoveIfWithoutAttributes
Summary: Share code between isStyleSpanOrSpanWithOnlyStyleAttribute, isUnstyledStyleSp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 12248
  Show dependency treegraph
 
Reported: 2011-08-11 13:29 PDT by Ryosuke Niwa
Modified: 2011-08-11 16:43 PDT (History)
6 users (show)

See Also:


Attachments
refactoring (7.61 KB, patch)
2011-08-11 14:30 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-08-11 13:29:18 PDT
The following functions all check similar conditions:
isStyleSpanOrSpanWithOnlyStyleAttribute
isUnstyledStyleSpan
isSpanWithoutAttributesOrUnstyleStyleSpan
ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes

We should merge them together.
Comment 1 Ryosuke Niwa 2011-08-11 14:30:36 PDT
Created attachment 103672 [details]
refactoring
Comment 2 Ryosuke Niwa 2011-08-11 16:11:59 PDT
Thanks for the review!
Comment 3 WebKit Review Bot 2011-08-11 16:43:25 PDT
Comment on attachment 103672 [details]
refactoring

Clearing flags on attachment: 103672

Committed r92891: <http://trac.webkit.org/changeset/92891>
Comment 4 WebKit Review Bot 2011-08-11 16:43:29 PDT
All reviewed patches have been landed.  Closing bug.