Bug 66089 - Chromium's WebKit API should use floats instead of doubles for zoom to match WebCore
Summary: Chromium's WebKit API should use floats instead of doubles for zoom to match ...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fady Samuel
URL:
Keywords:
Depends on: 66155
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-11 13:11 PDT by Fady Samuel
Modified: 2013-04-11 15:00 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.21 KB, patch)
2011-08-11 13:11 PDT, Fady Samuel
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fady Samuel 2011-08-11 13:11:20 PDT
Chromium's WebKit API should use floats instead of doubles for zoom to match WebCore
Comment 1 Fady Samuel 2011-08-11 13:11:41 PDT
Created attachment 103659 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-11 13:57:19 PDT
Comment on attachment 103659 [details]
Patch

Attachment 103659 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9371151
Comment 3 WebKit Review Bot 2011-08-12 11:43:50 PDT
Comment on attachment 103659 [details]
Patch

Clearing flags on attachment: 103659

Committed r92978: <http://trac.webkit.org/changeset/92978>
Comment 4 WebKit Review Bot 2011-08-12 11:43:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Fady Samuel 2011-08-24 13:54:40 PDT
This was reverted, but I can't figure out why? Will try to recommit...and keep an eye on what breaks...if anything..Adam?
Comment 6 Eric Seidel (no email) 2012-02-16 14:33:02 PST
What's the status here.  Did this get re-landed?  Does this need another review?
Comment 7 Ojan Vafai 2012-04-19 15:34:25 PDT
Comment on attachment 103659 [details]
Patch

It was rolled out because it doesn't compile apparently: http://trac.webkit.org/changeset/92980, but the EWS bots seem green now, so maybe whatever the problem was is resolved. Will try cq+ on it again.
Comment 8 WebKit Review Bot 2012-04-19 15:36:55 PDT
Comment on attachment 103659 [details]
Patch

Rejecting attachment 103659 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
.
Hunk #4 succeeded at 2210 (offset 355 lines).
patching file Source/WebKit/chromium/src/WebViewImpl.h
Hunk #1 FAILED at 151.
Hunk #2 succeeded at 507 with fuzz 2 (offset 118 lines).
Hunk #3 succeeded at 657 with fuzz 2 (offset 170 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/chromium/src/WebViewImpl.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ojan Vafai']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12297453