RESOLVED FIXED 66078
Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit 
https://bugs.webkit.org/show_bug.cgi?id=66078
Summary Clarify how the symbol and runtime-feature based test exclusion works and cle...
Eric Seidel (no email)
Reported 2011-08-11 11:07:16 PDT
Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
Attachments
Patch (13.82 KB, patch)
2011-08-11 11:14 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.36 KB, patch)
2011-11-06 11:48 PST, Eric Seidel (no email) 		eric: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-08-11 11:14:25 PDT
Created attachment 103647 [details] Patch
WebKit Review Bot
Comment 2 2011-11-06 11:36:20 PST
Comment on attachment 103647 [details] Patch Rejecting attachment 103647 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 6 with fuzz 1 (offset 14 lines). patching file Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py Hunk #1 succeeded at 43 (offset 3 lines). Hunk #2 succeeded at 60 (offset 3 lines). Hunk #3 FAILED at 96. Hunk #4 succeeded at 118 (offset 3 lines). 1 out of 4 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10337533
Eric Seidel (no email)
Comment 3 2011-11-06 11:48:00 PST
Created attachment 113794 [details] Patch for landing
Eric Seidel (no email)
Comment 4 2011-11-06 11:48:29 PST
Committed r99377: <http://trac.webkit.org/changeset/99377>
Ryosuke Niwa
Comment 5 2011-11-06 12:50:10 PST
It appears that this patch broke nrwt on SL: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/2871
Eric Seidel (no email)
Comment 6 2011-11-06 12:53:08 PST
OK. Looking.
Csaba Osztrogonác
Comment 7 2011-11-06 13:00:01 PST
(In reply to comment #5) > It appears that this patch broke nrwt on SL: > http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/2871 Not only SL, but NRWT on all bots.
Eric Seidel (no email)
Comment 8 2011-11-06 13:01:57 PST
Committed r99381: <http://trac.webkit.org/changeset/99381>
Eric Seidel (no email)
Comment 9 2011-11-06 13:05:45 PST
I believe I fixed the bots. Please let me know if that's not the case.
Note You need to log in before you can comment on or make changes to this bug.