Bug 66067 - Expose pageScaleFactor() to Chromium's WebViewImpl
Summary: Expose pageScaleFactor() to Chromium's WebViewImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fady Samuel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-11 09:35 PDT by Fady Samuel
Modified: 2011-08-12 15:56 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.89 KB, patch)
2011-08-11 09:35 PDT, Fady Samuel
no flags Details | Formatted Diff | Diff
Patch (3.01 KB, patch)
2011-08-11 12:15 PDT, Fady Samuel
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fady Samuel 2011-08-11 09:35:20 PDT
Expose pageScaleFactor() to Chromium's WebViewImpl
Comment 1 Fady Samuel 2011-08-11 09:35:56 PDT
Created attachment 103637 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2011-08-11 11:51:31 PDT
Comment on attachment 103637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103637&action=review

> Source/WebKit/chromium/public/WebView.h:206
> +    virtual double pageScaleFactor() const = 0;

it seems odd that this returns double when scalePage takes a float.  one of these should change to match the other.  zoom uses double.  maybe page scaling should use double too?
Comment 3 Fady Samuel 2011-08-11 12:15:44 PDT
Created attachment 103653 [details]
Patch
Comment 4 Fady Samuel 2011-08-12 09:31:52 PDT
(In reply to comment #3)
> Created an attachment (id=103653) [details]
> Patch

Fixed as suggested by fishd
Comment 5 WebKit Review Bot 2011-08-12 15:56:49 PDT
Comment on attachment 103653 [details]
Patch

Clearing flags on attachment: 103653

Committed r93007: <http://trac.webkit.org/changeset/93007>
Comment 6 WebKit Review Bot 2011-08-12 15:56:53 PDT
All reviewed patches have been landed.  Closing bug.