Bug 66050 - Web Inspector: Resources panel: display the current search match index in the toolbar.
Summary: Web Inspector: Resources panel: display the current search match index in the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks: 61119
  Show dependency tree / graph
 
Reported: 2011-08-11 06:17 PDT by Vsevolod Vlasov
Modified: 2011-10-25 06:48 PDT (History)
10 users (show)

See Also:

Attachments
Patch (8.24 KB, patch)
2011-08-11 06:26 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (22.71 KB, patch)
2011-10-25 03:23 PDT, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-08-11 06:17:21 PDT 
Resources panel: display the current search match index in the toolbar.
Comment 1 Vsevolod Vlasov 2011-08-11 06:26:04 PDT 
Created attachment 103613 [details]
Patch
Comment 2 Pavel Feldman 2011-08-11 07:55:11 PDT 
Comment on attachment 103613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103613&action=review

Too much logic here, please provide a test.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1632
> +            return this._searchResult(this._traverser.next(currentTreeElement), 0, this._currentMatchIndex % this._matchesCount + 1);

Why % ? Shouldn't _currentMatchIndex be normalized on its own?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1650
> +                return this._searchResult(treeElement, treeElement.searchMatchesCount - 1, currentMatchIndex);

I think this requires a test!
Comment 3 Vsevolod Vlasov 2011-10-25 03:23:51 PDT 
Created attachment 112314 [details]
Patch
Comment 4 Vsevolod Vlasov 2011-10-25 06:48:41 PDT 
Committed r98339: <http://trac.webkit.org/changeset/98339>