RESOLVED FIXED 66050
Web Inspector: Resources panel: display the current search match index in the toolbar. 
https://bugs.webkit.org/show_bug.cgi?id=66050
Summary Web Inspector: Resources panel: display the current search match index in the...
Vsevolod Vlasov
Reported 2011-08-11 06:17:21 PDT
Resources panel: display the current search match index in the toolbar.
Attachments
Patch (8.24 KB, patch)
2011-08-11 06:26 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (22.71 KB, patch)
2011-10-25 03:23 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-08-11 06:26:04 PDT
Created attachment 103613 [details] Patch
Pavel Feldman
Comment 2 2011-08-11 07:55:11 PDT
Comment on attachment 103613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103613&action=review Too much logic here, please provide a test. > Source/WebCore/inspector/front-end/ResourcesPanel.js:1632 > + return this._searchResult(this._traverser.next(currentTreeElement), 0, this._currentMatchIndex % this._matchesCount + 1); Why % ? Shouldn't _currentMatchIndex be normalized on its own? > Source/WebCore/inspector/front-end/ResourcesPanel.js:1650 > + return this._searchResult(treeElement, treeElement.searchMatchesCount - 1, currentMatchIndex); I think this requires a test!
Vsevolod Vlasov
Comment 3 2011-10-25 03:23:51 PDT
Created attachment 112314 [details] Patch
Vsevolod Vlasov
Comment 4 2011-10-25 06:48:41 PDT
Committed r98339: <http://trac.webkit.org/changeset/98339>
Note You need to log in before you can comment on or make changes to this bug.