Bug 66049 - IndexedDB: Object store records don't need to have keys in all indexes
Summary: IndexedDB: Object store records don't need to have keys in all indexes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-11 06:17 PDT by Hans Wennborg
Modified: 2011-08-12 02:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.94 KB, patch)
2011-08-11 06:22 PDT, Hans Wennborg 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2011-08-11 06:17:04 PDT 
IndexedDB: Object store records don't need to have keys in all indexes
Comment 1 Hans Wennborg 2011-08-11 06:22:12 PDT 
Created attachment 103611 [details]
Patch
Comment 2 Hans Wennborg 2011-08-11 06:26:15 PDT 
The relevant spec text is here: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-storing-a-record-into-an-object-store, where in 7.2 it says: "If index's key path is a string, then evaluate it on value. If this does not yield a value don't take any further actions for this index. Otherwise set the result to index key."

David, would you like to take a look?
Comment 3 David Grogan 2011-08-11 10:00:49 PDT 
Comment on attachment 103611 [details]
Patch

LGTM

Thanks for fixing this so fast.
Comment 4 Hans Wennborg 2011-08-11 10:01:55 PDT 
Tony: would you like to take a look?
Comment 5 Hans Wennborg 2011-08-12 02:32:51 PDT 
Committed r92951: <http://trac.webkit.org/changeset/92951>