Bug 66035 - Web Inspector: expand exception properties when wrapping it as object.
Summary: Web Inspector: expand exception properties when wrapping it as object.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-10 23:45 PDT by Pavel Feldman
Modified: 2011-08-12 07:52 PDT (History)
12 users (show)

See Also:


Attachments
[IMAGE] Screenshot. (18.57 KB, image/png)
2011-08-10 23:45 PDT, Pavel Feldman
no flags Details
Proposed fix(preliminary version) (5.75 KB, patch)
2011-08-11 07:58 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (2.63 KB, patch)
2011-08-12 06:48 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (9.72 KB, patch)
2011-08-12 07:46 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-08-10 23:45:19 PDT
Otherwise, exception is not informative: renders getters instead of values.
Comment 1 Pavel Feldman 2011-08-10 23:45:44 PDT
Created attachment 103584 [details]
[IMAGE] Screenshot.
Comment 2 Yury Semikhatsky 2011-08-11 07:58:27 PDT
Created attachment 103624 [details]
Proposed fix(preliminary version)
Comment 3 Yury Semikhatsky 2011-08-12 06:48:13 PDT
Created attachment 103768 [details]
Patch
Comment 4 Pavel Feldman 2011-08-12 06:52:47 PDT
Comment on attachment 103768 [details]
Patch

Please provide a test.
Comment 5 WebKit Review Bot 2011-08-12 07:15:58 PDT
Comment on attachment 103768 [details]
Patch

Attachment 103768 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9353623

New failing tests:
inspector/console/console-eval-global.html
inspector/console/console-eval-syntax-error.html
inspector/console/console-eval-undefined-override.html
inspector/runtime/runtime-setPropertyValue.html
Comment 6 Yury Semikhatsky 2011-08-12 07:46:23 PDT
Created attachment 103771 [details]
Patch
Comment 7 Yury Semikhatsky 2011-08-12 07:47:22 PDT
(In reply to comment #4)
> (From update of attachment 103768 [details])
> Please provide a test.

Done. The tests are already there, just needed to run them and rebaseline results.
Comment 8 Yury Semikhatsky 2011-08-12 07:52:18 PDT
Committed r92961: <http://trac.webkit.org/changeset/92961>