WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
66028
[EFL] Change condition checking logic related with both change of position and offset for backing store.
https://bugs.webkit.org/show_bug.cgi?id=66028
Summary
[EFL] Change condition checking logic related with both change of position an...
KwangHyuk
Reported
2011-08-10 19:16:32 PDT
As backing store's position and offset change can be occurred at the same time, the checking of offset change shouldn't be a "else if" statement.
Attachments
Patch,
(1.54 KB, patch)
2011-08-10 19:17 PDT
,
KwangHyuk
no flags
Details
Formatted Diff
Diff
Patch,
(1.54 KB, patch)
2011-08-10 19:26 PDT
,
KwangHyuk
aroben
: review-
Details
Formatted Diff
Diff
Patch.
(1.52 KB, patch)
2011-08-19 05:42 PDT
,
KwangHyuk
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
KwangHyuk
Comment 1
2011-08-10 19:17:55 PDT
Created
attachment 103569
[details]
Patch,
WebKit Review Bot
Comment 2
2011-08-10 19:20:20 PDT
Attachment 103569
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
KwangHyuk
Comment 3
2011-08-10 19:26:08 PDT
Created
attachment 103571
[details]
Patch,
Leandro Pereira
Comment 4
2011-08-12 07:05:33 PDT
Comment on
attachment 103571
[details]
Patch, Informal r+.
Gyuyoung Kim
Comment 5
2011-08-16 18:05:38 PDT
LGTM also.
Adam Roben (:aroben)
Comment 6
2011-08-19 05:30:21 PDT
Comment on
attachment 103571
[details]
Patch, View in context:
https://bugs.webkit.org/attachment.cgi?id=103571&action=review
> Source/WebKit/efl/ChangeLog:7 > + As backing store's position and offset change can be occurred at the same time, > + the checking of offset change shouldn't be a "else if" statement.
"can be occurred" should just be "can occur". 'a "else if"' should be 'an "else if"'.
KwangHyuk
Comment 7
2011-08-19 05:42:43 PDT
Created
attachment 104494
[details]
Patch.
KwangHyuk
Comment 8
2011-08-19 06:21:08 PDT
>"can be occurred" should just be "can occur". >'a "else if"' should be 'an "else if"'.
Patched. :-) Thank you for your review again.
WebKit Review Bot
Comment 9
2011-08-19 08:19:45 PDT
Comment on
attachment 104494
[details]
Patch. Clearing flags on attachment: 104494 Committed
r93409
: <
http://trac.webkit.org/changeset/93409
>
WebKit Review Bot
Comment 10
2011-08-19 08:19:50 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug