Bug 66025 – DFG non-speculative JIT does not inline the double case of ValueAdd

• Status: RESOLVED
• Resolution: INVALID
• Component: JavaScriptCore

[Filip Pizlo]

The DFG non-speculative JIT always performs a C call for ValueAdd if the operands are doubles.  It should inline the double case.

[Filip Pizlo]

Created attachment 103564 [details]
the patch

1.3% win on Kraken overall with >=8% speed-ups on three benchmarks.  Neutral on SunSpider, V8.

[Gavin Barraclough]

Comment on attachment 103564 [details]
the patch

done2 is a kinda weak name.  A full name would be something like valueAddDidConvertDoubleToInteger? - maybe that's a little long. ;-)  But something more descriptive than done2 might me nice.  Otherwise looks great, r+.

[Filip Pizlo]

Created attachment 104234 [details]
the patch (fix review)

I went with doneCaseConvertedToInt and doneCaseWasNumber.

[WebKit Review Bot]

Comment on attachment 104234 [details]
the patch (fix review)

Rejecting attachment 104234 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
rce/WebCore/ChangeLog
Auto-merging Source/WebCore/editing/InsertTextCommand.cpp
Failed to merge in the changes.
Patch failed at 0001 Remove arguments from CloseEvent::create().

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 146.

Full output: http://queues.webkit.org/results/9421491

[Filip Pizlo]

Landed manually in r93375: 
http://trac.webkit.org/changeset/93375

[Eric Seidel (no email)]

Comment on attachment 103564 [details]
the patch

Cleared Gavin Barraclough's review+ from obsolete attachment 103564 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Gavin Barraclough]

The DFG non-speculative JIT has been removed.