Bug 66023 – Web Inspector: Console logging of arrays is not useful

• Status: ASSIGNED
• Component: Web Inspector

[johnjbarton]

Open the attached html file and look at the console output. It's really impossible to tell what the array is really like. Firebug's output is too long but at least it gives you a sense of the array.

[johnjbarton]

Created attachment 103560 [details]
test case, look in Console

[Pavel Feldman]

We should enrich our formatting of both arrays and objects while inspector is visible to the one similar to FB. Unfortunately, opening inspector post-factum will still render things as they are (otherwise we need to spend too much time resolving/formatting objects).

Btw,
var aFlatArray = [];
for (var i = 0; i < 1000000; ++i) { aFlatArray[i] = i }
...will kill both Firebug and DevTools. I'm fixing it in https://bugs.webkit.org/show_bug.cgi?id=64596.

[Pavel Feldman]

Created attachment 104192 [details]
[IMAGE] Looks with patch applied.

[Pavel Feldman]

Created attachment 104206 [details]
[PATCH] Patch with no JSC baselines yet.

[Pavel Feldman]

Created attachment 104379 [details]
[PATCH] Proposed change

[WebKit Review Bot]

Comment on attachment 104379 [details]
[PATCH] Proposed change

Attachment 104379 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9424754

New failing tests:
inspector/console/console-log-toString-object.html

[Pavel Feldman]

Created attachment 104482 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 104482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104482&action=review

> LayoutTests/platform/chromium/inspector/console/console-eval-undefined-override-expected.txt:4
> +{a:1, self:, __proto__:}

There should be a value even if it's recursive.

> Source/WebCore/inspector/front-end/ConsoleView.js:796
>              if (name == parseInt(name))

Remove this and next lines and break when the length property is found.

[Pavel Feldman]

Created attachment 105164 [details]
[PATCH] Rebaselined.

[Pavel Feldman]

Comment on attachment 105164 [details]
[PATCH] Rebaselined.

Clearing r? for now.

[Paul Irish]

*** Bug 61427 has been marked as a duplicate of this bug. ***

[Radar WebKit Bug Importer]

<rdar://problem/19281460>