RESOLVED FIXED 66009
Refactoring of PopupMenuChromium For Readability and Maintainability 
https://bugs.webkit.org/show_bug.cgi?id=66009
Summary Refactoring of PopupMenuChromium For Readability and Maintainability
Fady Samuel
Reported 2011-08-10 13:36:48 PDT
Refactoring of PopupMenuChromium
Attachments
Patch (133.96 KB, patch)
2011-08-10 13:41 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (134.02 KB, patch)
2011-08-11 12:34 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (134.56 KB, patch)
2011-08-12 14:06 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (134.59 KB, patch)
2011-08-12 15:44 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2011-08-10 13:41:06 PDT
Created attachment 103529 [details] Patch
Fady Samuel
Comment 2 2011-08-11 12:34:07 PDT
Created attachment 103657 [details] Patch
Fady Samuel
Comment 3 2011-08-11 12:35:34 PDT
Updated the changelog as suggested by fishd.
WebKit Review Bot
Comment 4 2011-08-12 11:36:52 PDT
Comment on attachment 103657 [details] Patch Clearing flags on attachment: 103657 Committed r92976: <http://trac.webkit.org/changeset/92976>
WebKit Review Bot
Comment 5 2011-08-12 11:36:57 PDT
All reviewed patches have been landed. Closing bug.
Fady Samuel
Comment 6 2011-08-12 13:58:48 PDT
Broke a Windows test, reopening this.
Fady Samuel
Comment 7 2011-08-12 14:06:05 PDT
Created attachment 103813 [details] Patch
Darin Fisher (:fishd, Google)
Comment 8 2011-08-12 14:24:15 PDT
Comment on attachment 103813 [details] Patch OK
WebKit Review Bot
Comment 9 2011-08-12 14:58:12 PDT
Comment on attachment 103813 [details] Patch Rejecting attachment 103813 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: 3ca3f2e02eb286200861b2592d8582aab4cd124c r93002 = f4c76bcccb5f0317eba17e1f2b50a53674d23397 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9384004
WebKit Review Bot
Comment 10 2011-08-12 15:39:50 PDT
Comment on attachment 103813 [details] Patch Rejecting attachment 103813 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: bca0a5487e1ea7a520259fdbee2481f0cef8e958 r93005 = 61b5afdc0237a717f1d933ad24f1e95232a0713c Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9383020
Fady Samuel
Comment 11 2011-08-12 15:44:46 PDT
Created attachment 103829 [details] Patch
WebKit Review Bot
Comment 12 2011-08-12 16:19:03 PDT
Comment on attachment 103829 [details] Patch Clearing flags on attachment: 103829 Committed r93009: <http://trac.webkit.org/changeset/93009>
WebKit Review Bot
Comment 13 2011-08-12 16:19:09 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 14 2011-08-13 11:28:24 PDT
This patch does not compile on Clang: http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/6387/steps/compile/logs/stdio
Adam Barth
Comment 15 2011-08-13 11:32:04 PDT
Attempted fix in http://trac.webkit.org/changeset/93020
Note You need to log in before you can comment on or make changes to this bug.