Refactoring of PopupMenuChromium
Created attachment 103529 [details] Patch
Created attachment 103657 [details] Patch
Updated the changelog as suggested by fishd.
Comment on attachment 103657 [details] Patch Clearing flags on attachment: 103657 Committed r92976: <http://trac.webkit.org/changeset/92976>
All reviewed patches have been landed. Closing bug.
Broke a Windows test, reopening this.
Created attachment 103813 [details] Patch
Comment on attachment 103813 [details] Patch OK
Comment on attachment 103813 [details] Patch Rejecting attachment 103813 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: 3ca3f2e02eb286200861b2592d8582aab4cd124c r93002 = f4c76bcccb5f0317eba17e1f2b50a53674d23397 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9384004
Comment on attachment 103813 [details] Patch Rejecting attachment 103813 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: bca0a5487e1ea7a520259fdbee2481f0cef8e958 r93005 = 61b5afdc0237a717f1d933ad24f1e95232a0713c Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9383020
Created attachment 103829 [details] Patch
Comment on attachment 103829 [details] Patch Clearing flags on attachment: 103829 Committed r93009: <http://trac.webkit.org/changeset/93009>
This patch does not compile on Clang: http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/6387/steps/compile/logs/stdio
Attempted fix in http://trac.webkit.org/changeset/93020