Bug 66006 - The PageSerializer should always use absolute URL
Summary: The PageSerializer should always use absolute URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-10 13:07 PDT by Benjamin Poulain
Modified: 2011-08-11 15:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2011-08-11 10:00 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-08-10 13:07:01 PDT
In http://trac.webkit.org/changeset/92769/trunk/Source/WebCore/page/PageSerializer.cpp I added a Fixme for the URL resolution method.
I am pretty sure the existing resolving behavior is wrong or the code of the PageSerializer is wrong.

The url resources fetched are all stored with resolved URLs.
Comment 1 Benjamin Poulain 2011-08-11 10:00:42 PDT
Created attachment 103640 [details]
Patch
Comment 2 Benjamin Poulain 2011-08-11 10:04:42 PDT
This is a purely speculative patch that is completely untested :)

I left apart the privacy issues of exposing the local directory as this is not addressed by the current PageSerializer.
Comment 3 Benjamin Poulain 2011-08-11 13:13:18 PDT
Jay, any opinion?

I don't mind you guys reject the patch and the Chromium team take over to fix that with a test. I just wanted to point out a problem that become visible due to r92769.
Comment 4 Adam Barth 2011-08-11 13:15:53 PDT
Thanks Ben.  Let's see what Jay thinks we should do here.
Comment 5 Jay Civelli 2011-08-11 14:01:24 PDT
Yes, this patch is right.
We want to resolve all URLs including local ones.
Comment 6 Adam Barth 2011-08-11 14:02:56 PDT
Comment on attachment 103640 [details]
Patch

Ok.
Comment 7 WebKit Review Bot 2011-08-11 15:02:46 PDT
Comment on attachment 103640 [details]
Patch

Clearing flags on attachment: 103640

Committed r92883: <http://trac.webkit.org/changeset/92883>
Comment 8 WebKit Review Bot 2011-08-11 15:02:50 PDT
All reviewed patches have been landed.  Closing bug.