Bug 66004 – Remove ifdefs for CSS exclusions and CSS regions

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

CSS Exclusions have morphed into a different feature: positioned floats, and I don't want to try to maintain ifdefs in the float code for this, since that will just get pointlessly complicated. Regions also I would like to just turn on, since I expect them to share a bit of code with columns eventually, and I don't want that forked either. The specs are coming along, and I think it's ok to just have this on by default now.

[Dave Hyatt]

Created attachment 103519 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 103519 [details]
Patch

There are other FeatureDefines.xcconfig files that need to be modified (in places like Source/WebKit2/Configurations, e.g.). And you need to modify WebKitLibraries/win/tools/vsprops/FeatureDefines.*. And maybe other places for other ports, too. And you'll need to modify build-webkit to remove the Regions-related flags, and the files in Tools/BuildSlaveSupport/build.webkit.org-config that control how the CSSRegions bot operates.

[Dave Hyatt]

Created attachment 103525 [details]
Patch v2

[Adam Roben (:aroben)]

Comment on attachment 103525 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=103525&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:259
> -                    }
> +                    }                    }

Whoops.

You also need to delete the declaration of adobe-mac-slave1 higher up in the file.

[Dave Hyatt]

Fixed in r92792.

[Ryosuke Niwa]

This patch deleted the PlatformSpecificSchedule for all SnowLeopard bots :(.  Fixed in http://trac.webkit.org/changeset/92820.