RESOLVED FIXED 66002
Web Inspector: do not evaluate watch expressions on load. 
https://bugs.webkit.org/show_bug.cgi?id=66002
Summary Web Inspector: do not evaluate watch expressions on load.
Pavel Feldman
Reported 2011-08-10 12:09:30 PDT
Only do that upon scripts panel "show", stepping and reloads.
Attachments
Patch (5.76 KB, patch)
2011-08-10 12:27 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-08-10 12:27:21 PDT
Created attachment 103516 [details] Patch
Yury Semikhatsky
Comment 2 2011-08-10 23:20:54 PDT
Comment on attachment 103516 [details] Patch Is there a chance we have it tested?
Pavel Feldman
Comment 3 2011-08-10 23:25:36 PDT
Comment on attachment 103516 [details] Patch By the time we get control on the front-end, malicious watch update is already performed, not sure how to test this very case :(
Yury Semikhatsky
Comment 4 2011-08-10 23:44:16 PDT
(In reply to comment #3) > (From update of attachment 103516 [details]) > By the time we get control on the front-end, malicious watch update is already performed, not sure how to test this very case :( Well, the watch expression can have a side effect on the inspected page, say increment a counter in it and we can check that after frontend opening it has not been incremented yet. We would need to issue a request on the very early stage of the frontend loading though.
WebKit Review Bot
Comment 5 2011-08-11 00:56:29 PDT
Comment on attachment 103516 [details] Patch Clearing flags on attachment: 103516 Committed r92827: <http://trac.webkit.org/changeset/92827>
WebKit Review Bot
Comment 6 2011-08-11 00:56:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.