Bug 66002 - Web Inspector: do not evaluate watch expressions on load.
Summary: Web Inspector: do not evaluate watch expressions on load.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-10 12:09 PDT by Pavel Feldman
Modified: 2011-08-11 00:56 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.76 KB, patch)
2011-08-10 12:27 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-08-10 12:09:30 PDT 
Only do that upon scripts panel "show", stepping and reloads.
Comment 1 Pavel Feldman 2011-08-10 12:27:21 PDT 
Created attachment 103516 [details]
Patch
Comment 2 Yury Semikhatsky 2011-08-10 23:20:54 PDT 
Comment on attachment 103516 [details]
Patch

Is there a chance we have it tested?
Comment 3 Pavel Feldman 2011-08-10 23:25:36 PDT 
Comment on attachment 103516 [details]
Patch

By the time we get control on the front-end, malicious watch update is already performed, not sure how to test this very case :(
Comment 4 Yury Semikhatsky 2011-08-10 23:44:16 PDT 
(In reply to comment #3)
> (From update of attachment 103516 [details])
> By the time we get control on the front-end, malicious watch update is already performed, not sure how to test this very case :(

Well, the watch expression can have a side effect on the inspected page, say increment a counter in it and we can check that after frontend opening it has not been incremented yet. We would need to issue a request on the very early stage of the frontend loading though.
Comment 5 WebKit Review Bot 2011-08-11 00:56:29 PDT 
Comment on attachment 103516 [details]
Patch

Clearing flags on attachment: 103516

Committed r92827: <http://trac.webkit.org/changeset/92827>
Comment 6 WebKit Review Bot 2011-08-11 00:56:34 PDT 
All reviewed patches have been landed.  Closing bug.