Bug 65998 – [Qt] Enable WebGL by default for QtWebKit (except on Windows)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Noam Rosenthal]

It's time to make building WebGL on Qt an opt-out instead of an opt-in.
We'd still keep it opt-in in the settings.

[Noam Rosenthal]

Created attachment 103542 [details]
Patch

[Benjamin Poulain]

Comment on attachment 103542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103542&action=review

> Source/WebCore/features.pri:125
> +contains(QT_CONFIG, opengl) {

Before you land, could you check if that still work on Qt5? ...since gl is always available there?

[Noam Rosenthal]

(In reply to comment #2)
> (From update of attachment 103542 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=103542&action=review
> 
> > Source/WebCore/features.pri:125
> > +contains(QT_CONFIG, opengl) {
> 
> Before you land, could you check if that still work on Qt5? ...since gl is always available there?

You mean does the flag work?
Checked. Works.

[WebKit Review Bot]

Comment on attachment 103542 [details]
Patch

Clearing flags on attachment: 103542

Committed r92805: <http://trac.webkit.org/changeset/92805>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

It broke all fast/canvas/webgl tests ...
I skipped them: https://trac.webkit.org/changeset/92805

Reopen to fix them or file a bug report.

[Csaba Osztrogonác]

And it broke Windows build too ...
Reni had to disable WebGL on Windows: https://trac.webkit.org/changeset/92830

[Benjamin Poulain]

(In reply to comment #7)
> And it broke Windows build too ...
> Reni had to disable WebGL on Windows: https://trac.webkit.org/changeset/92830

Interesting. I guess we will have to investigate ANGLE sooner than expected.

[Csaba Osztrogonác]

Why did you close it? WebGL is still disabled on Windows ...

[Noam Rosenthal]

(In reply to comment #9)
> Why did you close it? WebGL is still disabled on Windows ...

It's confusing. We should create a new bug specificly for windows.

[Csaba Osztrogonác]

Reni filed a new bug report about it, but missed to mention it here:
https://bugs.webkit.org/show_bug.cgi?id=66042

[Noam Rosenthal]

Thanks for changing the bug desc. - I should have done that when closing the bug.