Bug 65995 - Clean up ChromiumDriver a little
Summary: Clean up ChromiumDriver a little
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-10 10:25 PDT by Eric Seidel (no email)
Modified: 2011-08-10 11:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.92 KB, patch)
2011-08-10 10:26 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Fix typo caught by test-webkitpy (10.93 KB, patch)
2011-08-10 10:28 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-08-10 10:25:13 PDT 
Clean up ChromiumDriver a little
Comment 1 Eric Seidel (no email) 2011-08-10 10:26:42 PDT 
Created attachment 103501 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-08-10 10:28:47 PDT 
Created attachment 103503 [details]
Fix typo caught by test-webkitpy
Comment 3 Eric Seidel (no email) 2011-08-10 10:30:01 PDT 
I got here because I was looking at all use of ServerProcess and found that ChromiumDriver (surprisingly!) does not use the ServerProcess abstraction.
Comment 4 Adam Barth 2011-08-10 10:43:55 PDT 
Comment on attachment 103503 [details]
Fix typo caught by test-webkitpy

View in context: https://bugs.webkit.org/attachment.cgi?id=103503&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:487
>                      raise e

You should just say "raise" instead of "raise e".  That re-raises the original exception.
Comment 5 WebKit Review Bot 2011-08-10 10:58:14 PDT 
Comment on attachment 103503 [details]
Fix typo caught by test-webkitpy

Clearing flags on attachment: 103503

Committed r92777: <http://trac.webkit.org/changeset/92777>
Comment 6 WebKit Review Bot 2011-08-10 10:58:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 James Robinson 2011-08-10 11:36:04 PDT 
Stack:


Starting testing ...Process _Process-1:
Traceback (most recent call last):
  File "/usr/lib/python2.6/multiprocessing/process.py", line 232, in _bootstrap
    self.run()
  File "/usr/local/google/home/jamesr/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py", line 268, in run
worker/0 raised AttributeError('ChromiumDriver instance has no attribute '_proc''):
  layout_tests/controllers/worker.py:91 (in run)
    self._worker_connection.run_message_loop()
  layout_tests/controllers/message_broker.py:191 (in run_message_loop)
    self._broker.run_message_loop(self._run_topic, self._client, delay_secs)
  layout_tests/controllers/message_broker.py:127 (in run_message_loop)
    self._run_loop(topic_name, client, block=True, delay_secs=delay_secs)
  layout_tests/controllers/message_broker.py:141 (in _run_loop)
    self._dispatch_message(msg, client)
  layout_tests/controllers/message_broker.py:150 (in _dispatch_message)
    message_handler(message.src, *optargs)
  layout_tests/controllers/worker.py:111 (in handle_test_list)
    self._run_test(test_input)
  layout_tests/controllers/worker.py:126 (in _run_test)
    result = self.run_test_with_timeout(test_input, test_timeout_sec)
  layout_tests/controllers/worker.py:165 (in run_test_with_timeout)
    return self._run_test_in_this_thread(test_input)
  layout_tests/controllers/worker.py:249 (in _run_test_in_this_thread)
    self._driver.start()
  layout_tests/port/chromium.py:437 (in start)
    assert not self._proc