Bug 65995 – Clean up ChromiumDriver a little

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Clean up ChromiumDriver a little

[Eric Seidel (no email)]

Created attachment 103501 [details]
Patch

[Eric Seidel (no email)]

Created attachment 103503 [details]
Fix typo caught by test-webkitpy

[Eric Seidel (no email)]

I got here because I was looking at all use of ServerProcess and found that ChromiumDriver (surprisingly!) does not use the ServerProcess abstraction.

[Adam Barth]

Comment on attachment 103503 [details]
Fix typo caught by test-webkitpy

View in context: https://bugs.webkit.org/attachment.cgi?id=103503&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:487
>                      raise e

You should just say "raise" instead of "raise e".  That re-raises the original exception.

[WebKit Review Bot]

Comment on attachment 103503 [details]
Fix typo caught by test-webkitpy

Clearing flags on attachment: 103503

Committed r92777: <http://trac.webkit.org/changeset/92777>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[James Robinson]

Stack:


Starting testing ...Process _Process-1:
Traceback (most recent call last):
  File "/usr/lib/python2.6/multiprocessing/process.py", line 232, in _bootstrap
    self.run()
  File "/usr/local/google/home/jamesr/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py", line 268, in run
worker/0 raised AttributeError('ChromiumDriver instance has no attribute '_proc''):
  layout_tests/controllers/worker.py:91 (in run)
    self._worker_connection.run_message_loop()
  layout_tests/controllers/message_broker.py:191 (in run_message_loop)
    self._broker.run_message_loop(self._run_topic, self._client, delay_secs)
  layout_tests/controllers/message_broker.py:127 (in run_message_loop)
    self._run_loop(topic_name, client, block=True, delay_secs=delay_secs)
  layout_tests/controllers/message_broker.py:141 (in _run_loop)
    self._dispatch_message(msg, client)
  layout_tests/controllers/message_broker.py:150 (in _dispatch_message)
    message_handler(message.src, *optargs)
  layout_tests/controllers/worker.py:111 (in handle_test_list)
    self._run_test(test_input)
  layout_tests/controllers/worker.py:126 (in _run_test)
    result = self.run_test_with_timeout(test_input, test_timeout_sec)
  layout_tests/controllers/worker.py:165 (in run_test_with_timeout)
    return self._run_test_in_this_thread(test_input)
  layout_tests/controllers/worker.py:249 (in _run_test_in_this_thread)
    self._driver.start()
  layout_tests/port/chromium.py:437 (in start)
    assert not self._proc