Bug 65989 - Accidentally commented out an assertion in BackingStore::incorporateUpdate
Summary: Accidentally commented out an assertion in BackingStore::incorporateUpdate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-10 09:00 PDT by Alexey Proskuryakov
Modified: 2011-08-10 11:30 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (1.27 KB, patch)
2011-08-10 10:27 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-08-10 09:00:31 PDT 
This wasn't reviewed, and definitely shouldn't have been landed: <http://trac.webkit.org/changeset/78426/trunk/Source/WebKit2/UIProcess/BackingStore.cpp>.

Clearly, the assertion was firing a lot, but I don't remember if that had anything to do with r78426, or was just something I already had in my tree for livability. I'm going to uncomment it locally and live with that for a while to see if the assertion fires.

See also: <rdar://problem/8994456>.
Comment 1 Alexey Proskuryakov 2011-08-10 10:27:27 PDT 
Created attachment 103502 [details]
proposed patch
Comment 2 WebKit Review Bot 2011-08-10 11:30:23 PDT 
Comment on attachment 103502 [details]
proposed patch

Clearing flags on attachment: 103502

Committed r92778: <http://trac.webkit.org/changeset/92778>
Comment 3 WebKit Review Bot 2011-08-10 11:30:27 PDT 
All reviewed patches have been landed.  Closing bug.