65965 – Implement internals.computedStyleIncludingVisitedInfo()

UNCONFIRMED 65965

Implement internals.computedStyleIncludingVisitedInfo()

https://bugs.webkit.org/show_bug.cgi?id=65965

Summary Implement internals.computedStyleIncludingVisitedInfo()

Kentaro Hara

Reported 2011-08-10 00:15:27 PDT

On Chromium, Gtk and win, layoutTestController.computedStyleIncludingVisitedInfo() is not implemented. (See bug 37297, bug 37336 and bug 37337). We should implement internals.computedStyleIncludingVisitedInfo(), which can be used by all platforms.

Attachments
Patch (42.20 KB, patch) 2011-08-10 00:18 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
Patch (43.76 KB, patch) 2011-08-10 01:31 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
Patch (44.22 KB, patch) 2011-08-10 01:46 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
Patch (40.63 KB, patch) 2011-08-11 02:30 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
to ask cq (40.79 KB, patch) 2011-08-11 23:06 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (40.75 KB, patch) 2011-08-14 18:11 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (40.09 KB, patch) 2011-11-25 01:30 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
Patch (40.10 KB, patch) 2011-11-25 02:09 PST, Kentaro Hara	gustavo: commit-queue-	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2011-08-10 00:18:59 PDT

Created attachment 103448 [details] Patch

Gustavo Noronha (kov)

Comment 2 2011-08-10 00:26:02 PDT

Comment on attachment 103448 [details] Patch Attachment 103448 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9333693

Early Warning System Bot

Comment 3 2011-08-10 00:27:19 PDT

Comment on attachment 103448 [details] Patch Attachment 103448 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9332705

Kentaro Hara

Comment 4 2011-08-10 01:31:44 PDT

Created attachment 103451 [details] Patch

Gustavo Noronha (kov)

Comment 5 2011-08-10 01:39:48 PDT

Comment on attachment 103451 [details] Patch Attachment 103451 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9344102

Kentaro Hara

Comment 6 2011-08-10 01:46:12 PDT

Created attachment 103453 [details] Patch

Hajime Morrita

Comment 7 2011-08-11 00:00:33 PDT

Comment on attachment 103453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103453&action=review > ChangeLog:8 > + - Implemented internals.computedStyleIncludingVisitedInfo(), which can be used by all platforms. This should be at Source/WebCore/ChangeLog > ChangeLog:9 > + - Replaced layoutTestController.computedStyleIncludingVisitedInfo() in tests This should be at LayoutTests/ChangeLog > ChangeLog:12 > + platform-dependent codes. This should be at each of Source/WebKit/*/ChangeLog > LayoutTests/ChangeLog:2 > + Ditto. > LayoutTests/fast/history/multiple-classes-visited.html:11 > + var firstStyle = window.internals.computedStyleIncludingVisitedInfo(document.getElementById('one')); Need to check window.internals to make the test runnable outside DRT. > LayoutTests/fast/history/nested-visited-test.html:-17 > - if (window.layoutTestController) { Need to check window.internals to make the test runnable outside DRT. > LayoutTests/fast/history/nested-visited-test.html:-50 > -<script> Don't touch unrelated code if possible. > LayoutTests/fast/history/self-is-visited.html:-11 > - if (window.layoutTestController) { Ditto. > LayoutTests/fast/history/sibling-visited-test.html:-11 > - if (window.layoutTestController) { Ditto. > LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited.html:-13 > - if (window.layoutTestController) { Ditto.

Kentaro Hara

Comment 8 2011-08-11 02:30:08 PDT

Created attachment 103595 [details] Patch

Gustavo Noronha (kov)

Comment 9 2011-08-11 04:32:37 PDT

Comment on attachment 103595 [details] Patch Attachment 103595 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9351153

Hajime Morrita

Comment 10 2011-08-11 21:41:47 PDT

Comment on attachment 103595 [details] Patch Code looks good for me. Let's make bots happy.

Hajime Morrita

Comment 11 2011-08-11 23:06:52 PDT

Created attachment 103739 [details] to ask cq

WebKit Review Bot

Comment 12 2011-08-11 23:08:26 PDT

Attachment 103739 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 ERROR: Failed to detect Windows version, assuming latest. [Errno 2] No such file or directory ERROR: FAILURES FOR <lucid, x86_64, release, cpu> ERROR: Line:261 Path does not exist. platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html LayoutTests/platform/chromium/test_expectations.txt:261: Path does not exist. platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html [test/expectations] [2] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Hajime Morrita

Comment 13 2011-08-14 18:11:25 PDT

Created attachment 103888 [details] Patch

WebKit Review Bot

Comment 14 2011-08-15 11:09:43 PDT

Attachment 103888 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 ERROR: Failed to detect Windows version, assuming latest. [Errno 2] No such file or directory ERROR: FAILURES FOR <lucid, x86_64, release, cpu> ERROR: Line:261 Path does not exist. platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html LayoutTests/platform/chromium/test_expectations.txt:261: Path does not exist. platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html [test/expectations] [2] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Hajime Morrita

Comment 15 2011-08-15 20:59:23 PDT

Comment on attachment 103888 [details] Patch r- at this time. At least we need to add symbol list for windows.

Hajime Morrita

Comment 16 2011-11-22 00:43:33 PST

Assigning this to haraken.

Kentaro Hara

Comment 17 2011-11-25 01:30:55 PST

Created attachment 116581 [details] Patch

Early Warning System Bot

Comment 18 2011-11-25 01:40:39 PST

Comment on attachment 116581 [details] Patch Attachment 116581 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10644569

Gustavo Noronha (kov)

Comment 19 2011-11-25 01:41:02 PST

Comment on attachment 116581 [details] Patch Attachment 116581 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10644570

WebKit Review Bot

Comment 20 2011-11-25 02:01:29 PST

Comment on attachment 116581 [details] Patch Attachment 116581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10647390

Kentaro Hara

Comment 21 2011-11-25 02:09:38 PST

Created attachment 116584 [details] Patch

Gustavo Noronha (kov)

Comment 22 2011-11-25 04:09:56 PST

Comment on attachment 116584 [details] Patch Attachment 116584 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10602811

Note You need to log in before you can comment on or make changes to this bug.

Status UNCONFIRMED

Resolution

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS All

Product WebKit

Component Tools / Tests

Assignee

Kentaro Hara

Reported

2011-08-10 00:15 PDT

Modified

2011-11-25 04:10 PST History

CC List

5 users Show

URL

Keywords

Depends on

Blocks