On Chromium, Gtk and win, layoutTestController.computedStyleIncludingVisitedInfo() is not implemented. (See bug 37297, bug 37336 and bug 37337). We should implement internals.computedStyleIncludingVisitedInfo(), which can be used by all platforms.
Created attachment 103448 [details] Patch
Comment on attachment 103448 [details] Patch Attachment 103448 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9333693
Comment on attachment 103448 [details] Patch Attachment 103448 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9332705
Created attachment 103451 [details] Patch
Comment on attachment 103451 [details] Patch Attachment 103451 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9344102
Created attachment 103453 [details] Patch
Comment on attachment 103453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103453&action=review > ChangeLog:8 > + - Implemented internals.computedStyleIncludingVisitedInfo(), which can be used by all platforms. This should be at Source/WebCore/ChangeLog > ChangeLog:9 > + - Replaced layoutTestController.computedStyleIncludingVisitedInfo() in tests This should be at LayoutTests/ChangeLog > ChangeLog:12 > + platform-dependent codes. This should be at each of Source/WebKit/*/ChangeLog > LayoutTests/ChangeLog:2 > + Ditto. > LayoutTests/fast/history/multiple-classes-visited.html:11 > + var firstStyle = window.internals.computedStyleIncludingVisitedInfo(document.getElementById('one')); Need to check window.internals to make the test runnable outside DRT. > LayoutTests/fast/history/nested-visited-test.html:-17 > - if (window.layoutTestController) { Need to check window.internals to make the test runnable outside DRT. > LayoutTests/fast/history/nested-visited-test.html:-50 > -<script> Don't touch unrelated code if possible. > LayoutTests/fast/history/self-is-visited.html:-11 > - if (window.layoutTestController) { Ditto. > LayoutTests/fast/history/sibling-visited-test.html:-11 > - if (window.layoutTestController) { Ditto. > LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited.html:-13 > - if (window.layoutTestController) { Ditto.
Created attachment 103595 [details] Patch
Comment on attachment 103595 [details] Patch Attachment 103595 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9351153
Comment on attachment 103595 [details] Patch Code looks good for me. Let's make bots happy.
Created attachment 103739 [details] to ask cq
Attachment 103739 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 ERROR: Failed to detect Windows version, assuming latest. [Errno 2] No such file or directory ERROR: FAILURES FOR <lucid, x86_64, release, cpu> ERROR: Line:261 Path does not exist. platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html LayoutTests/platform/chromium/test_expectations.txt:261: Path does not exist. platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html [test/expectations] [2] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 103888 [details] Patch
Attachment 103888 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 ERROR: Failed to detect Windows version, assuming latest. [Errno 2] No such file or directory ERROR: FAILURES FOR <lucid, x86_64, release, cpu> ERROR: Line:261 Path does not exist. platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html LayoutTests/platform/chromium/test_expectations.txt:261: Path does not exist. platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html [test/expectations] [2] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 103888 [details] Patch r- at this time. At least we need to add symbol list for windows.
Assigning this to haraken.
Created attachment 116581 [details] Patch
Comment on attachment 116581 [details] Patch Attachment 116581 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10644569
Comment on attachment 116581 [details] Patch Attachment 116581 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10644570
Comment on attachment 116581 [details] Patch Attachment 116581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10647390
Created attachment 116584 [details] Patch
Comment on attachment 116584 [details] Patch Attachment 116584 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10602811