Bug 65964 – [Chromium] plugins/keyboard-events.html should pass on linux/mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[noel gordon]

Final sea of red. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fkeyboard-events.html

[noel gordon]

Created attachment 103450 [details]
Patch

[noel gordon]

I note the linux result outputs an empty keycode -- that is a progression.  There is a FIXME note in the test plugin code about that:
  http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp?rev=88712#L644

The FIXME code is there, keyEventToChar(), but it produces an empty char with the chromium linux DRT. 
  http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp?rev=88712#L623

This because the chromium linux DRT creates a keyboard event but fails to fill in the native GTK keycode in that field of the event.

[Tony Chang]

Do we know why we get an empty keycode with Chromium's DRT?  It seems to be working for GTK+.

[noel gordon]

(In reply to comment #3)
> Do we know why we get an empty keycode with Chromium's DRT?  It seems to be working for GTK+.

The GTK port creates an honest to goodness GdkEvent keypress event
  http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/gtk/EventSender.cpp?rev=85516#L612

Chromium's DRT generates a WebKeyboardEvent, defined by the webkit api
  http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/EventSender.cpp?rev=85516#L566

and fills in the WebKeyboardEvent.windowsKeyCode field, but not the nativeKeyCode field
  http://trac.webkit.org/browser/trunk/WebKit/chromium/public/WebInputEvent.h?rev=50721#L153

The plugin is sent the nativeKeyCode value.  That works in the real browser case, but not with
the Chromium DRT.  Is there a table somewhere that maps webkit::VKEY_CODE to native key codes?

[noel gordon]

Created attachment 104655 [details]
Patch sync up.

[Tony Chang]

Comment on attachment 104655 [details]
Patch sync up.

Seems fine.  I filed bug 66679 about fixing the missing key codes.  Seems OK to just add a table for use by chromium's drt.

[WebKit Review Bot]

Comment on attachment 104655 [details]
Patch sync up.

Clearing flags on attachment: 104655

Committed r93519: <http://trac.webkit.org/changeset/93519>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[noel gordon]

The Skia for the Mac transition is now active.  Move the chromium mac keyboard-events.html result to
platform/chromium-cg-mac while this transition happens.  http://trac.webkit.org/changeset/93554.