Bug 65962 – Web Inspector: live edit both for JS and CSS is not discoverable.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

FB's Live Edit button makes it more explicit.

[Alexander Pavlov (apavlov)]

Created attachment 106730 [details]
[PATCH] Suggested solution

This is the first take on the feature. The button placement seems a bit odd in the Resources panel, and suggestions on a better "Live Edit" glyph are most welcome.

[Alexander Pavlov (apavlov)]

Created attachment 106731 [details]
[PATCH] Style fixed

[Yury Semikhatsky]

Comment on attachment 106730 [details]
[PATCH] Suggested solution

View in context: https://bugs.webkit.org/attachment.cgi?id=106730&action=review

> Source/WebCore/ChangeLog:6
> +	Add the "Edit" button to SourceFrame, so that resources/scripts can be edited both in the

Wrong alignment.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1148
> +    _toggleEditSource: function()

This is never called, r- for this.

[Yury Semikhatsky]

Comment on attachment 106731 [details]
[PATCH] Style fixed

View in context: https://bugs.webkit.org/attachment.cgi?id=106731&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:47
> +    this._editButton.addEventListener("click", this._editButtonClicked.bind(this, true), this);

_editButtonClicked expects no parameters, no need to bind it to "true".

> Source/WebCore/inspector/front-end/SourceFrame.js:838
> +            if (!this.startEditing())

You can omit the if, just call the method.

[Yury Semikhatsky]

Comment on attachment 106731 [details]
[PATCH] Style fixed

View in context: https://bugs.webkit.org/attachment.cgi?id=106731&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:922
> +        this._container.focus();

Move this call after the check below?

[Alexander Pavlov (apavlov)]

Created attachment 106737 [details]
[PATCH] Comments addressed

[Alexander Pavlov (apavlov)]

Created attachment 106738 [details]
[PATCH] Binary diff (with the changed glyph image)

[Alexander Pavlov (apavlov)]

Committed r94842: <http://trac.webkit.org/changeset/94842>