Bug 65950 - WKPageCopyPendingAPIRequestURL returns stale result if policy decision set to Ignore
Summary: WKPageCopyPendingAPIRequestURL returns stale result if policy decision set to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: John Sullivan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-08-09 17:03 PDT by John Sullivan
Modified: 2011-08-09 17:11 PDT (History)
0 users

See Also:


Attachments
Patch to clear the pending API request when PolicyIgnore is received. (1.23 KB, patch)
2011-08-09 17:05 PDT, John Sullivan
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2011-08-09 17:03:01 PDT
When the policy decision is set by the client to PolicyIgnore, there's no code to clear the pending API request (though clearly no API request is pending any more). Then if the client asks for it later via WKPageCopyPendingAPIRequestURL, a non-null answer is returned, which fools the client into thinking that some sort of load is still underway.

This is in Radar as <rdar://problem/9925931>
Comment 1 John Sullivan 2011-08-09 17:05:52 PDT
Created attachment 103420 [details]
Patch to clear the pending API request when PolicyIgnore is received.
Comment 2 John Sullivan 2011-08-09 17:10:05 PDT
Fixed in <http://trac.webkit.org/changeset/92729>.
Comment 3 John Sullivan 2011-08-09 17:11:41 PDT
I r+’ed my own patch in a moment of absent-mindedness. However, Anders Carlsson also gave me an r+, so I will still be able to sleep at night.