Bug 65907 - [Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap
Summary: [Qt] Vastly improve the algorithm for finding a zoomable area when doing doub...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
Depends on:
Reported: 2011-08-09 04:02 PDT by Kenneth Rohde Christiansen
Modified: 2011-08-09 07:12 PDT (History)
3 users (show)

See Also:

Patch (9.83 KB, patch)
2011-08-09 04:04 PDT, Kenneth Rohde Christiansen
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (9.83 KB, patch)
2011-08-09 06:09 PDT, Kenneth Rohde Christiansen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2011-08-09 04:02:49 PDT
Comment 1 Kenneth Rohde Christiansen 2011-08-09 04:04:25 PDT
Created attachment 103344 [details]
Comment 2 Andreas Kling 2011-08-09 05:58:52 PDT
Comment on attachment 103344 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=103344&action=review


Two comments though. First, I think if we keep this as public API, we should rework it to have proper request/response mapping (though the point/rect mapping that this patch introduces is certainly better than what we had before.) I don't believe this mechanism should be public though, as it could be completely handled by the respective views.

Second, after this patch, a FindZoomableAreaForPoint request can now yield no response whatsoever. Given how the "end-user signal" is used, I don't see a problem with it, and I'm assuming this is intentional. Just making a note here in case it wasn't.

> Source/WebKit2/ChangeLog:12
> +
> +

Double newline yo.
Comment 3 Kenneth Rohde Christiansen 2011-08-09 06:09:51 PDT
Created attachment 103350 [details]
Patch for landing
Comment 4 WebKit Review Bot 2011-08-09 07:11:13 PDT
Comment on attachment 103350 [details]
Patch for landing

Clearing flags on attachment: 103350

Committed r92680: <http://trac.webkit.org/changeset/92680>
Comment 5 WebKit Review Bot 2011-08-09 07:11:17 PDT
All reviewed patches have been landed.  Closing bug.