Bug 65893 - Chromium Windows bots can't figure out what SVN revision they're running
Summary: Chromium Windows bots can't figure out what SVN revision they're running
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-08 17:57 PDT by Adam Barth
Modified: 2011-08-08 18:26 PDT (History)
2 users (show)

See Also:


Attachments
Patch (12.47 KB, patch)
2011-08-08 17:59 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (12.91 KB, patch)
2011-08-08 18:04 PDT, Adam Barth
eric: review+
abarth: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-08-08 17:57:56 PDT
Chromium Windows bots can't figure out what SVN revision they're running
Comment 1 Adam Barth 2011-08-08 17:59:39 PDT
Created attachment 103322 [details]
Patch
Comment 2 Adam Barth 2011-08-08 18:04:07 PDT
Created attachment 103323 [details]
Patch
Comment 3 Eric Seidel (no email) 2011-08-08 18:07:18 PDT
Comment on attachment 103323 [details]
Patch

Looks OK.  WE really should use a self.run_svn() function instead so we don't poop self.exectutable_name all over the place.
Comment 4 Adam Barth 2011-08-08 18:26:35 PDT
Committed r92660: <http://trac.webkit.org/changeset/92660>