Bug 65887 - handle child margin values when flexing
Summary: handle child margin values when flexing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency tree / graph
 
Reported: 2011-08-08 16:13 PDT by Tony Chang
Modified: 2011-08-22 14:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.21 KB, patch)
2011-08-08 16:15 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (10.27 KB, patch)
2011-08-08 16:22 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (10.86 KB, patch)
2011-08-22 11:18 PDT, Tony Chang 		hyatt: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-08-08 16:13:25 PDT 
handle child margin values when flexing
Comment 1 Tony Chang 2011-08-08 16:15:18 PDT 
Created attachment 103309 [details]
Patch
Comment 2 Gyuyoung Kim 2011-08-08 16:18:34 PDT 
Comment on attachment 103309 [details]
Patch

Attachment 103309 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9335146
Comment 3 WebKit Review Bot 2011-08-08 16:19:58 PDT 
Comment on attachment 103309 [details]
Patch

Attachment 103309 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9330634
Comment 4 Early Warning System Bot 2011-08-08 16:22:09 PDT 
Comment on attachment 103309 [details]
Patch

Attachment 103309 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9332197
Comment 5 Tony Chang 2011-08-08 16:22:44 PDT 
Created attachment 103310 [details]
Patch
Comment 6 Dave Hyatt 2011-08-22 10:39:13 PDT 
Comment on attachment 103310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103310&action=review

> Source/WebCore/rendering/RenderBox.cpp:1637
> +#if ENABLE(CSS3_FLEXBOX)
> +            && !cb->isFlexibleBox()
> +#endif
> +            && !cb->isDeprecatedFlexibleBox())

I imagine this will come up again, so it seems like a method that wrapped both of these would be useful. Then you don't have ifdefs at all the call sites either.
Comment 7 Tony Chang 2011-08-22 11:18:02 PDT 
Created attachment 104700 [details]
Patch
Comment 8 Dave Hyatt 2011-08-22 13:33:09 PDT 
Comment on attachment 104700 [details]
Patch

r=me
Comment 9 Tony Chang 2011-08-22 14:49:16 PDT 
Committed r93547: <http://trac.webkit.org/changeset/93547>