RESOLVED FIXED 65878
scm.delete should delete empty parent directories as well 
https://bugs.webkit.org/show_bug.cgi?id=65878
Summary scm.delete should delete empty parent directories as well
Adam Barth
Reported 2011-08-08 14:29:40 PDT
scm.delete should delete empty parent directories as well
Attachments
Patch (5.89 KB, patch)
2011-08-08 14:33 PDT, Adam Barth 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-08-08 14:33:23 PDT
Created attachment 103295 [details] Patch
Eric Seidel (no email)
Comment 2 2011-08-08 17:05:45 PDT
Comment on attachment 103295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103295&action=review LGTM if you fix the self._filesystem issues. > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:179 > + if set(os.listdir(path)) - self._svn_metadata_files: Seems this should be self._filtesystem.listdir(). Also do we have other ignored files we should exclude? > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:182 > + dirname = os.path.dirname(path) self._filesystem. > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:188 > + abs_path = os.path.abspath(path) > + parent, base = os.path.split(abs_path) more self._filesystem.
Adam Barth
Comment 3 2011-08-08 17:10:44 PDT
Comment on attachment 103295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103295&action=review >> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:182 >> + dirname = os.path.dirname(path) > > self._filesystem. Yeah, that's the right thing to do, but I don't see any code in svn.py that uses filesystem. Maybe you never landed that patch? These examples are all parallel with _add_parent_directories above.
Adam Barth
Comment 4 2011-08-08 17:11:36 PDT
Committed r92655: <http://trac.webkit.org/changeset/92655>
Note You need to log in before you can comment on or make changes to this bug.