Bug 65873 - Deprecate rebaseline-chromium-webkit-tests
: Deprecate rebaseline-chromium-webkit-tests
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Adam Barth
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-08 13:32 PDT by Adam Barth
Modified: 2011-08-10 13:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2011-08-08 13:35 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-08-08 13:32:50 PDT
Deprecate rebaseline-chromium-webkit-tests
Comment 1 Adam Barth 2011-08-08 13:35:17 PDT
Created attachment 103287 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-08 14:38:10 PDT
Comment on attachment 103287 [details]
Patch

Clearing flags on attachment: 103287

Committed r92637: <http://trac.webkit.org/changeset/92637>
Comment 3 WebKit Review Bot 2011-08-08 14:38:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 James Robinson 2011-08-10 13:44:22 PDT
This patch adds a deprecation warning, but AFAIK webkit-patch rebaseline-expectations doesn't know about the chromium canaries, so there is a *significant* functionality loss.  I don't think that a chromium gardener today can actually use rebaseline-expectations to do their job so this warning is misleading at best.
Comment 5 Adam Barth 2011-08-10 13:52:12 PDT
Have you tried using the script?  It does know about the Chromium canaries.
Comment 6 James Robinson 2011-08-10 13:54:38 PDT
Woah, deep magic.  Never mind, then :)