Bug 65871 – Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements lookup

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Alexandru Chiculita]

This is a retry on bug 65668 - Optimize floating elements lookup that was rolled out by the commit bot.

[Alexandru Chiculita]

Created attachment 103284 [details]
Patch

"positionNewFloatOnLine" is moving the object, so it had to remove it from the tree, move it and add it back in the tree. "removePlacedObject" also sets the isPlaced to false, so the call to x() or y() would assert about isPlaced being false. Now I saved the old position on stack before calling removePlacedObject, so that the assert is avoided.

[Dave Hyatt]

Comment on attachment 103284 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 103284 [details]
Patch

Rejecting attachment 103284 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
ILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/platform/PODIntervalTree.h
patching file Source/WebCore/platform/PODRedBlackTree.h
patching file Source/WebCore/rendering/RenderBlock.cpp
patching file Source/WebCore/rendering/RenderBlock.h
patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Hyatt', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9211121

[Dave Hyatt]

Landed this by hand in r92696.

[Alexandru Chiculita]

Created attachment 103383 [details]
Patch

Rebased the patch

[Hajime Morrita]

Comment on attachment 103383 [details]
Patch

Removing r? since the patch is already landed.