Bug 65871 - Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements lookup
Summary: Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-08-08 13:20 PDT by Alexandru Chiculita
Modified: 2011-08-15 21:19 PDT (History)
2 users (show)

See Also:

Patch (51.68 KB, patch)
2011-08-08 13:30 PDT, Alexandru Chiculita
hyatt: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (51.58 KB, patch)
2011-08-09 12:17 PDT, Alexandru Chiculita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2011-08-08 13:20:01 PDT
This is a retry on bug 65668 - Optimize floating elements lookup that was rolled out by the commit bot.
Comment 1 Alexandru Chiculita 2011-08-08 13:30:30 PDT
Created attachment 103284 [details]

"positionNewFloatOnLine" is moving the object, so it had to remove it from the tree, move it and add it back in the tree. "removePlacedObject" also sets the isPlaced to false, so the call to x() or y() would assert about isPlaced being false. Now I saved the old position on stack before calling removePlacedObject, so that the assert is avoided.
Comment 2 Dave Hyatt 2011-08-09 10:00:20 PDT
Comment on attachment 103284 [details]

Comment 3 WebKit Review Bot 2011-08-09 10:02:30 PDT
Comment on attachment 103284 [details]

Rejecting attachment 103284 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
ILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/platform/PODIntervalTree.h
patching file Source/WebCore/platform/PODRedBlackTree.h
patching file Source/WebCore/rendering/RenderBlock.cpp
patching file Source/WebCore/rendering/RenderBlock.h
patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Hyatt', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9211121
Comment 4 Dave Hyatt 2011-08-09 12:14:06 PDT
Landed this by hand in r92696.
Comment 5 Alexandru Chiculita 2011-08-09 12:17:54 PDT
Created attachment 103383 [details]

Rebased the patch
Comment 6 Hajime Morrita 2011-08-15 21:19:04 PDT
Comment on attachment 103383 [details]

Removing r? since the patch is already landed.