Bug 65853 - [EFL] Return from _ewk_view_smart_add if smart data can not be allocated
Summary: [EFL] Return from _ewk_view_smart_add if smart data can not be allocated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-08 06:08 PDT by Grzegorz Czajkowski
Modified: 2011-08-10 17:54 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (4.45 KB, patch)
2011-08-08 06:10 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2011-08-08 06:08:53 PDT 
This patch prevents crash when malloc fails for sd structure. As you can see, only return statement in _ewk_view_smart_add wasn't enough. To display an empty window (without view) others NULL checks were needed. I tested the patch on both the backing stores.

We should be aware that these checks may influence on performance. Anyway this defect has been marked as one of important bugs in WebKit-EFL.
What is your opinion about that?
Comment 1 Grzegorz Czajkowski 2011-08-08 06:10:10 PDT 
Created attachment 103237 [details]
proposed patch
Comment 2 Leandro Pereira 2011-08-08 07:44:49 PDT 
Comment on attachment 103237 [details]
proposed patch

Informal r+.
Comment 3 Gyuyoung Kim 2011-08-08 17:35:11 PDT 
Comment on attachment 103237 [details]
proposed patch

LGTM also.
Comment 4 Leandro Pereira 2011-08-09 07:06:40 PDT 
*** Bug 65408 has been marked as a duplicate of this bug. ***
Comment 5 Kenneth Rohde Christiansen 2011-08-09 07:35:51 PDT 
Comment on attachment 103237 [details]
proposed patch

LGTM
Comment 6 Gyuyoung Kim 2011-08-10 17:42:42 PDT 
Comment on attachment 103237 [details]
proposed patch

LGTM.
Comment 7 WebKit Review Bot 2011-08-10 17:54:54 PDT 
Comment on attachment 103237 [details]
proposed patch

Clearing flags on attachment: 103237

Committed r92808: <http://trac.webkit.org/changeset/92808>
Comment 8 WebKit Review Bot 2011-08-10 17:54:59 PDT 
All reviewed patches have been landed.  Closing bug.