Bug 65844 - [EFL] API methods check NULL and return proper value
Summary: [EFL] API methods check NULL and return proper value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-08 00:53 PDT by Grzegorz Czajkowski
Modified: 2011-08-10 04:53 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (5.12 KB, patch)
2011-08-08 00:54 PDT, Grzegorz Czajkowski
kenneth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
updated patch (5.13 KB, patch)
2011-08-10 02:39 PDT, Grzegorz Czajkowski
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2011-08-08 00:53:28 PDT
Check NULL before access to the smart and private data of the view object and return the proper value if error occurred.
Comment 1 Grzegorz Czajkowski 2011-08-08 00:54:14 PDT
Created attachment 103216 [details]
proposed patch
Comment 2 Gyuyoung Kim 2011-08-08 01:04:52 PDT
Comment on attachment 103216 [details]
proposed patch

LGTM
Comment 3 Leandro Pereira 2011-08-08 07:26:37 PDT
Comment on attachment 103216 [details]
proposed patch

LGTM also.
Comment 4 WebKit Review Bot 2011-08-10 02:06:00 PDT
Comment on attachment 103216 [details]
proposed patch

Rejecting attachment 103216 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
ctor/network-status-non-http.html = TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE

Regressions: Unexpected image and text mismatch : (1)
  svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT



Full output: http://queues.webkit.org/results/9344110
Comment 5 Gyuyoung Kim 2011-08-10 02:19:46 PDT
It looks chromium port reports error during the LayoutTest. I think this patch doesn't influence on chromium port. 

Hello Grzegorz, 

Could you submit this patch again ?
Comment 6 Grzegorz Czajkowski 2011-08-10 02:39:53 PDT
Created attachment 103457 [details]
updated patch

Just added Kenneth Rohde Christiansen to the reviewer filed.
Could you add this patch to commit-queue one more time, please?
Comment 7 WebKit Review Bot 2011-08-10 04:53:44 PDT
Comment on attachment 103457 [details]
updated patch

Clearing flags on attachment: 103457

Committed r92763: <http://trac.webkit.org/changeset/92763>
Comment 8 WebKit Review Bot 2011-08-10 04:53:49 PDT
All reviewed patches have been landed.  Closing bug.