RESOLVED FIXED Bug 65844
[EFL] API methods check NULL and return proper value 
https://bugs.webkit.org/show_bug.cgi?id=65844
Summary [EFL] API methods check NULL and return proper value
Grzegorz Czajkowski
Reported 2011-08-08 00:53:28 PDT
Check NULL before access to the smart and private data of the view object and return the proper value if error occurred.
Attachments
proposed patch (5.12 KB, patch)
2011-08-08 00:54 PDT, Grzegorz Czajkowski 		kenneth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
updated patch (5.13 KB, patch)
2011-08-10 02:39 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2011-08-08 00:54:14 PDT
Created attachment 103216 [details] proposed patch
Gyuyoung Kim
Comment 2 2011-08-08 01:04:52 PDT
Comment on attachment 103216 [details] proposed patch LGTM
Leandro Pereira
Comment 3 2011-08-08 07:26:37 PDT
Comment on attachment 103216 [details] proposed patch LGTM also.
WebKit Review Bot
Comment 4 2011-08-10 02:06:00 PDT
Comment on attachment 103216 [details] proposed patch Rejecting attachment 103216 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: ctor/network-status-non-http.html = TEXT Regressions: Unexpected image mismatch : (5) fast/text/atsui-multiple-renderers.html = IMAGE fast/text/international/danda-space.html = IMAGE fast/text/international/thai-baht-space.html = IMAGE fast/text/international/thai-line-breaks.html = IMAGE platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE Regressions: Unexpected image and text mismatch : (1) svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT Full output: http://queues.webkit.org/results/9344110
Gyuyoung Kim
Comment 5 2011-08-10 02:19:46 PDT
It looks chromium port reports error during the LayoutTest. I think this patch doesn't influence on chromium port. Hello Grzegorz, Could you submit this patch again ?
Grzegorz Czajkowski
Comment 6 2011-08-10 02:39:53 PDT
Created attachment 103457 [details] updated patch Just added Kenneth Rohde Christiansen to the reviewer filed. Could you add this patch to commit-queue one more time, please?
WebKit Review Bot
Comment 7 2011-08-10 04:53:44 PDT
Comment on attachment 103457 [details] updated patch Clearing flags on attachment: 103457 Committed r92763: <http://trac.webkit.org/changeset/92763>
WebKit Review Bot
Comment 8 2011-08-10 04:53:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.