VERIFIED FIXED 6584
REGRESSION: button after unclosed button gives trouble
https://bugs.webkit.org/show_bug.cgi?id=6584
Summary REGRESSION: button after unclosed button gives trouble
Joost de Valk (AlthA)
Reported 2006-01-16 04:57:36 PST
This renders a button inside a button in latest nightly: <button/>test <button>test2</button> adding testcase in a sec.
Attachments
Testcase (325 bytes, text/html)
2006-01-16 04:58 PST, Joost de Valk (AlthA)
no flags
Patch v1 (5.53 KB, patch)
2006-01-30 20:45 PST, David Kilzer (:ddkilzer)
hyatt: review+
Expected image v1 (16.82 KB, image/png)
2006-01-30 20:57 PST, David Kilzer (:ddkilzer)
no flags
Joost de Valk (AlthA)
Comment 1 2006-01-16 04:58:41 PST
Created attachment 5717 [details] Testcase When serverd as xhtml this goes fine, just an html issue.
Joost de Valk (AlthA)
Comment 2 2006-01-22 04:43:17 PST
Upping to P1 because this is a regression.
Darin Adler
Comment 3 2006-01-24 21:15:19 PST
Believe it or not, this is an HTML parser issue. It's the parser that's responsible for rules about closing tags that are left open. And this is an example of a <button> tag that's left open, since in HTML, <button/> does not count as a closed tag even though in XHTML it is self-closing.
Darin Adler
Comment 4 2006-01-29 10:09:52 PST
Dave told me to put code in the parser like what we have for other elements that close themselves (including <p>elements). I tried, and my first cut doesn't work yet.
Darin Adler
Comment 5 2006-01-30 01:25:16 PST
I'm throwing this one back. I can't figure out how to fix it even though Dave says it's easy and I think someone else can handle it.
David Kilzer (:ddkilzer)
Comment 6 2006-01-30 20:45:31 PST
Created attachment 6130 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 7 2006-01-30 20:57:05 PST
Created attachment 6131 [details] Expected image v1
Dave Hyatt
Comment 8 2006-01-30 20:59:03 PST
Comment on attachment 6130 [details] Patch v1 r=me.
Eric Seidel (no email)
Comment 9 2006-01-31 21:20:42 PST
Removing Regression keyword from bugs already fixed.
David Kilzer (:ddkilzer)
Comment 10 2006-02-01 04:44:47 PST
Verified fixed on nightly r12504.
Note You need to log in before you can comment on or make changes to this bug.