Bug 65836 – Dump-as-markup conversion: nested-blocks-with-text-area.html and nested-blocks-with-text-field.html

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

editing/pasteboard/nested-blocks-with-text-area.html and editing/pasteboard/nested-blocks-with-text-field.html should be converted to dump-as-markup tests so that the output can be understood more easily.

[Ryosuke Niwa]

Note that these 2 tests refer to \n at the end of fragments should not be rendered, this is an issue with whitespace rebalancing, and not about the actual rendering so these 2 tests do not require pixel tests to demonstrate the bug 11475.

[Ryosuke Niwa]

Created attachment 103195 [details]
converted the tests

[Kent Tamura]

Comment on attachment 103195 [details]
converted the tests

View in context: https://bugs.webkit.org/attachment.cgi?id=103195&action=review

> LayoutTests/platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png:0
> -PNG
> -
> -
>  IHDR XvpsBIT|d	pHYsÄÄ+)tEXtchecksumf0a00aa52c536db4a97787ecbd1842b6Þ IDATxíÝu?þ×þI@ãMQÓUÛËݲLËÊ6/S,@"ÓÄ,ÑíªT´fzu)Ù¸eYkºm)J«®¶¡º¡bh±.V¸ 2óúþÁwÎÎfÎ9syØãq]s1ç>ç~ÿºß÷û>OÎiÉÌ~¹Í@7øë!Å @1P#Å @1P#Å @1PLÝré¥ÆàÁãSúT\}õÕÑÒÒ---1{öì8묳bèСqÚi§EDÄÌ3+÷?öØcýÞøz|òÉ8ûì³·¨6½Z¼òÊ+ñ¯ÿú¯ñ·¼¥Ûq­wo~ó]Íã?^9^Õ?7ÝtSe¿·¾õ­Üß}÷5Ýþ»_~yL2%î¹çhii{é2ÚÚÚú¤McK;¿;ëËsýg#8"9æØc=â+®¨»OM3íøkQj.^xá=ÖÓèû¾°Å7%ÔuØõ¶pYÇìÙ³óK.©Ü\¾|yffÎ7/O9åÌÌÜ°aÃ&÷´-±M͸öÚków¿ûÝQÞÕW_GqDãZïþ?üpî°Ã]sÃ

The patch looks weird.

[Ryosuke Niwa]

(In reply to comment #3)
> (From update of attachment 103195 [details])
> > LayoutTests/platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png:0
> > -PNG
> > -
> > -
> >  IHDR XvpsBIT|d	pHYsÄÄ+)tEXtchecksumf0a00aa52c536db4a97787ecbd1842b6Þ IDATxíÝu?þ×þI@ãMQÓUÛËݲLËÊ6/S,@"ÓÄ,ÑíªT´fzu)Ù¸eYkºm)J«®¶¡º¡bh±.V¸ 2óúþÁwÎÎfÎ9syØãq]s1ç>ç~ÿºß÷û>OÎiÉÌ~¹Í@7øë!Å @1P#Å @1P#Å @1PLÝré¥ÆàÁãSúT\}õÕÑÒÒ---1{öì8묳bèСqÚi§EDÄÌ3+÷?öØcýÞøz|òÉ8ûì³·¨6½Z¼òÊ+ñ¯ÿú¯ñ·¼¥Ûq­wo~ó]Íã?^9^Õ?7ÝtSe¿·¾õ­Üß}÷5Ýþ»_~yL2%î¹çhii{é2ÚÚÚú¤McK;¿;ëËsýg#8"9æØc=â+®¨»OM3íøkQj.^xá=ÖÓèû¾°Å7%ÔuØõ¶pYÇìÙ³óK.©Ü\¾|yffÎ7/O9åÌÌÜ°aÃ&÷´-±M͸öÚków¿ûÝQÞÕW_GqDãZïþ?üpî°Ã]sÃ
> 
> The patch looks weird.

That's because the existing file in the repository has a wrong mime type :(

[Kent Tamura]

Comment on attachment 103195 [details]
converted the tests

ok anyway.
I'm not sure commit-queue can handle this.

[Ryosuke Niwa]

(In reply to comment #5)
> (From update of attachment 103195 [details])
> ok anyway.
> I'm not sure commit-queue can handle this.

That's a good point.  We'll see how it goes.

[WebKit Review Bot]

Comment on attachment 103195 [details]
converted the tests

Rejecting attachment 103195 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
 LayoutTests/platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt
rm 'LayoutTests/platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt'
patching file LayoutTests/platform/win/editing/pasteboard/nested-blocks-with-text-area-expected.txt
rm 'LayoutTests/platform/win/editing/pasteboard/nested-blocks-with-text-area-expected.txt'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 2

Full output: http://queues.webkit.org/results/9329625

[Ryosuke Niwa]

Committed r92578: <http://trac.webkit.org/changeset/92578>

[Ryosuke Niwa]

Thanks for the reviews!