Bug 65826 - [WK2] Export WebCoreSupport::injectInternalsObject.
Summary: [WK2] Export WebCoreSupport::injectInternalsObject.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Holger Freyther
URL:
Keywords:
Depends on:
Blocks: 65470
  Show dependency tree / graph
 
Reported: 2011-08-07 04:32 PDT by Holger Freyther
Modified: 2012-05-31 11:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2011-08-07 04:32 PDT, Holger Freyther 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Reduce symbols (force enabling of export macros) (2.39 KB, patch)
2011-08-07 04:40 PDT, Holger Freyther 		no flags Details | Formatted Diff | Diff
Use WEBKIT_EXPORTDATA (4.22 KB, patch)
2011-08-08 05:03 PDT, Holger Freyther 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2011-08-07 04:32:45 PDT 
Created attachment 103178 [details]
Patch

Export injectInternalsObject for WebKitTestRunner (inject bundle). This is required
when using -fvisibility=hidden for WebCore symbols. The export macros come from
bug #27551, the re-introduction of -fvisibility=hidden is tracked in bug #65470.
Comment 1 WebKit Review Bot 2011-08-07 04:35:00 PDT 
Attachment 103178 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Holger Freyther 2011-08-07 04:40:23 PDT 
Created attachment 103179 [details]
Reduce symbols (force enabling of export macros)

This maybe should wait for bug #27551 to be resolved first. The stripped library I get on x86 is:
29616930 2011-08-07 07:48 lib/libQtWebKit.so.4.10.0
Comment 3 WebKit Review Bot 2011-08-07 04:46:06 PDT 
Comment on attachment 103178 [details]
Patch

Attachment 103178 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9329452
Comment 4 WebKit Review Bot 2011-08-07 04:48:42 PDT 
Comment on attachment 103178 [details]
Patch

Attachment 103178 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9324568
Comment 5 Holger Freyther 2011-08-08 05:03:30 PDT 
Created attachment 103230 [details]
Use WEBKIT_EXPORTDATA

build tested on chromium
Comment 6 Darin Adler 2011-10-17 13:04:52 PDT 
Comment on attachment 103230 [details]
Use WEBKIT_EXPORTDATA

Looks like this breaks the Windows build. Please fix that before landing.
Comment 7 Alexey Proskuryakov 2012-05-31 11:21:22 PDT 
Is this still needed?