NEW 65826
[WK2] Export WebCoreSupport::injectInternalsObject.
https://bugs.webkit.org/show_bug.cgi?id=65826
Summary [WK2] Export WebCoreSupport::injectInternalsObject.
Holger Freyther
Reported Sunday, August 7, 2011 12:32:45 PM UTC
Created attachment 103178 [details] Patch Export injectInternalsObject for WebKitTestRunner (inject bundle). This is required when using -fvisibility=hidden for WebCore symbols. The export macros come from bug #27551, the re-introduction of -fvisibility=hidden is tracked in bug #65470.
Attachments
Patch (1.96 KB, patch)
2011-08-07 04:32 PDT, Holger Freyther
webkit.review.bot: commit-queue-
Reduce symbols (force enabling of export macros) (2.39 KB, patch)
2011-08-07 04:40 PDT, Holger Freyther
no flags
Use WEBKIT_EXPORTDATA (4.22 KB, patch)
2011-08-08 05:03 PDT, Holger Freyther
darin: review+
WebKit Review Bot
Comment 1 Sunday, August 7, 2011 12:35:00 PM UTC
Attachment 103178 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Holger Freyther
Comment 2 Sunday, August 7, 2011 12:40:23 PM UTC
Created attachment 103179 [details] Reduce symbols (force enabling of export macros) This maybe should wait for bug #27551 to be resolved first. The stripped library I get on x86 is: 29616930 2011-08-07 07:48 lib/libQtWebKit.so.4.10.0
WebKit Review Bot
Comment 3 Sunday, August 7, 2011 12:46:06 PM UTC
Comment on attachment 103178 [details] Patch Attachment 103178 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9329452
WebKit Review Bot
Comment 4 Sunday, August 7, 2011 12:48:42 PM UTC
Comment on attachment 103178 [details] Patch Attachment 103178 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9324568
Holger Freyther
Comment 5 Monday, August 8, 2011 1:03:30 PM UTC
Created attachment 103230 [details] Use WEBKIT_EXPORTDATA build tested on chromium
Darin Adler
Comment 6 Monday, October 17, 2011 9:04:52 PM UTC
Comment on attachment 103230 [details] Use WEBKIT_EXPORTDATA Looks like this breaks the Windows build. Please fix that before landing.
Alexey Proskuryakov
Comment 7 Thursday, May 31, 2012 7:21:22 PM UTC
Is this still needed?
Note You need to log in before you can comment on or make changes to this bug.