Bug 65808 - [Chromium] Remove HaltablePlugin references from gyp project files
Summary: [Chromium] Remove HaltablePlugin references from gyp project files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-05 19:56 PDT by noel gordon
Modified: 2011-08-05 21:28 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.08 KB, patch)
2011-08-05 19:59 PDT, noel gordon
no flags Details | Formatted Diff | Diff
Patch (1.14 KB, patch)
2011-08-05 20:05 PDT, noel gordon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2011-08-05 19:56:26 PDT
HaltablePlugin and related were removed in r92492.
Comment 1 noel gordon 2011-08-05 19:59:37 PDT
Created attachment 103142 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-05 20:02:13 PDT
Attachment 103142 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 noel gordon 2011-08-05 20:05:28 PDT
Created attachment 103143 [details]
Patch
Comment 4 WebKit Review Bot 2011-08-05 21:14:15 PDT
Comment on attachment 103143 [details]
Patch

Clearing flags on attachment: 103143

Committed r92544: <http://trac.webkit.org/changeset/92544>
Comment 5 WebKit Review Bot 2011-08-05 21:14:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 noel gordon 2011-08-05 21:28:18 PDT
jeanluc: WebKit produces no warnings during gyp project file generation on VS2010 now.  Remaining warnings are few in number.

Warning: Missing input file src\native_client\src\trusted\platform_qualify\arch\x86\nacl_cpuwhitelist.h
Warning: Missing input file src\v8\tools\gyp\..\..\src\codegen-inl.h
Warning: Missing input file src\native_client\src\trusted\platform_qualify\arch\x86\nacl_cpuwhitelist.h
Warning: Missing input file src\views\views_api.h
Warning: Missing input file src\third_party\flac\src\libFLAC\include\private\nasm.h
Warning: Missing input file src\third_party\angle\src\compiler\unistd.h