Both of these: if (RetainPtr<CFDataRef> bodyData = CFURLRequestCopyHTTPRequestBody(request)) return FormData::create(CFDataGetBytePtr(bodyData.get()), CFDataGetLength(bodyData.get())); if (RetainPtr<CFArrayRef> bodyParts = wkCFURLRequestCopyHTTPRequestBodyParts(request)) { RefPtr<FormData> formData = FormData::create(); Cause leaks because RetainPtr::operation= will CFRetain() but FooCopyBar() already returns a +1 allocation. We should adopt the reference with AdoptCF.
Created attachment 103104 [details] [PATCH] Proposed Fix
Comment on attachment 103104 [details] [PATCH] Proposed Fix cq- based on the bot failing to build on Windows.
Windows build bot says: http://queues.webkit.org/results/9323095 3>####### COMPILING 2 FILES USING AT MOST 8 PARALLEL INSTANCES OF cl.exe ########### 3>FormDataStreamCFNet.cpp 3>..\platform\network\cf\FormDataStreamCFNet.cpp(94) : error C2061: syntax error : identifier 'AdoptCF' 3>..\platform\network\cf\FormDataStreamCFNet.cpp(94) : error C2059: syntax error : ')' 3>..\platform\network\cf\FormDataStreamCFNet.cpp(95) : error C2143: syntax error : missing ';' before 'return' 3>..\platform\network\cf\FormDataStreamCFNet.cpp(95) : error C2065: 'bodyData' : undeclared identifier 3>..\platform\network\cf\FormDataStreamCFNet.cpp(95) : error C2228: left of '.get' must have class/struct/union 3> type is ''unknown-type'' 3>..\platform\network\cf\FormDataStreamCFNet.cpp(95) : error C2228: left of '.get' must have class/struct/union 3> type is ''unknown-type'' This built fine for me locally. Maybe the Window's compiler doesn't like the shorthand constructor syntax inside of an if statement? I could move the assignments outside of the if statements if needed. Adding some windows developers.
s/if statement/if condition/
Created attachment 103117 [details] [PATCH] Fix Build Issue With Previous Patch I forgot that by default PLATFORM(MAC) doesn't take this path by default. So my local build was a false positive. I've now tested building this change correctly.
Comment on attachment 103117 [details] [PATCH] Fix Build Issue With Previous Patch r=me
Comment on attachment 103117 [details] [PATCH] Fix Build Issue With Previous Patch Clearing flags on attachment: 103117 Committed r92530: <http://trac.webkit.org/changeset/92530>
All reviewed patches have been landed. Closing bug.