Bug 65784 - Web Inspector: Network panel always displays file:// resources as "(pending)"
Summary: Web Inspector: Network panel always displays file:// resources as "(pending)"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-05 12:22 PDT by Andrey Kosyakov
Modified: 2011-08-10 01:27 PDT (History)
12 users (show)

See Also:


Attachments
patch (2.10 KB, patch)
2011-08-05 12:34 PDT, Andrey Kosyakov
pfeldman: review-
Details | Formatted Diff | Diff
patch (4.78 KB, patch)
2011-08-08 07:11 PDT, Andrey Kosyakov
pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-08-05 12:22:59 PDT
1. Open inspector
2. Switch to the Network panel
3. Navigate to a file:// url
3. Observe that all file URLs have status of "(pending)"
Comment 1 Andrey Kosyakov 2011-08-05 12:34:12 PDT
Created attachment 103095 [details]
patch

- report status for non-http(s?) resources that are finished and not failed as "Success"
- "(Pending)" -> "(pending)" for consistency with other bogus status values
Comment 2 Pavel Feldman 2011-08-08 01:09:56 PDT
(you should not regress data url behavior).
btw: a test for file: and data: would be great.
Comment 3 Andrey Kosyakov 2011-08-08 07:11:14 PDT
Created attachment 103239 [details]
patch

- added a test

note that data URL behavior is not actually regressed: we used to have "(data url)" as a status for data URLs, now it's just "Success".
Comment 4 Pavel Feldman 2011-08-08 10:05:55 PDT
Comment on attachment 103239 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103239&action=review

> LayoutTests/inspector/network-status-non-http.html:5
> +test = function() {

function test() {

> LayoutTests/inspector/network-status-non-http.html:14
> +        var dataGrid = logView.element.querySelector("table.data");

what is dataGrid.textContent ?

> LayoutTests/inspector/network-status-non-http.html:44
> +function addElement(src)

addScriptElement

> LayoutTests/inspector/network-status-non-http.html:48
> +    document.body.appendChild(element);

document.head.appendChild
Comment 5 WebKit Review Bot 2011-08-08 10:49:28 PDT
Comment on attachment 103239 [details]
patch

Attachment 103239 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9330533

New failing tests:
inspector/network-status-non-http.html
Comment 6 Andrey Kosyakov 2011-08-10 01:27:08 PDT
Manually committed r92755: http://trac.webkit.org/changeset/92755