Bug 65777 – Add testing for --force-compositing-mode to windows.internal

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Adrienne Walker]

There's currently no way to test the force compositing mode flag in DRT.  This should be fixed.

[Adrienne Walker]

Created attachment 103130 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 103130 [details]
Patch

Attachment 103130 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9317519

[James Robinson]

I believe when touching window.internals you have to muck about with a whole bunch of export files.  Is that right, Dimitri?

[Dimitri Glazkov (Google)]

(In reply to comment #3)
> I believe when touching window.internals you have to muck about with a whole bunch of export files.  Is that right, Dimitri?

Yes indeedy. That's what those busted EWS bubbles say.

[Adam Barth]

Comment on attachment 103130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103130&action=review

> Source/WebCore/testing/Internals.cpp:195
> +void Internals::setForceCompositingMode(Document* document, bool enabled, ExceptionCode& ec)
> +{
> +    if (!document) {
> +        ec = INVALID_ACCESS_ERR;
> +        return;
> +    }
> +
> +    Settings* settings = document->settings();
> +    if (!settings) {
> +        ec = INVALID_ACCESS_ERR;
> +        return;
> +    }
> +    settings->setForceCompositingMode(enabled);
> +}

This looks like a bunch of boilerplate.  Should we make a macro so do this work?  I guess it's the first one, so maybe we should wait until we have more than one.  :)

[WebKit Review Bot]

Comment on attachment 103130 [details]
Patch

Attachment 103130 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9317537

[Hajime Morrita]

(In reply to comment #5)
> (From update of attachment 103130 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=103130&action=review
> 
> > Source/WebCore/testing/Internals.cpp:195
> > +void Internals::setForceCompositingMode(Document* document, bool enabled, ExceptionCode& ec)
> > +{
> > +    if (!document) {
> > +        ec = INVALID_ACCESS_ERR;
> > +        return;
> > +    }
> > +
> > +    Settings* settings = document->settings();
> > +    if (!settings) {
> > +        ec = INVALID_ACCESS_ERR;
> > +        return;
> > +    }
> > +    settings->setForceCompositingMode(enabled);
> > +}
> 
> This looks like a bunch of boilerplate.  Should we make a macro so do this work?  I guess it's the first one, so maybe we should wait until we have more than one.  :)
It would be cool if WebKitIDL supported [ConvertNullToException=INVALID_ACCESS_ERR].

[Adrienne Walker]

Created attachment 103278 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 103278 [details]
Patch

Attachment 103278 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9336002

[Adrienne Walker]

Created attachment 103286 [details]
Patch

[Adrienne Walker]

Created attachment 103305 [details]
Patch

[Adrienne Walker]

(In reply to comment #11)
> Created an attachment (id=103305) [details]
> Patch

Finally.  All green.  :)

Does anybody have any feedback other than reducing boilerplate?

[Adrienne Walker]

Committed r92697: <http://trac.webkit.org/changeset/92697>