Bug 65774 – [Qt] ASSERTION FAILED: !hasDataLabel()

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Jocelyn Turcotte]

ASSERTION FAILED: !hasDataLabel()
../../../Source/JavaScriptCore/yarr/YarrJIT.cpp(653) : void JSC::Yarr::YarrGenerator::BacktrackDestination::setDataLabel(JSC::AbstractMacroAssembler<JSC::X86Assembler>::DataLabelPtr)

Reproduced from r91843 with QtTestBrowser on linux in debug. Just had to log in to facebook, I could see my home page flash and the assert would pop.

[Jocelyn Turcotte]

Humm sorry the svn revision doesn't mean much, from 883ca7eae6dedfd2caddbaf8b95a51795aa13268 in qtwebkit/qtwebkit-2.2.

[Jocelyn Turcotte]

This file was last changed 3 days before 2.2 was branched, and this change removed the assert (among many other things) 11 days after the branch.
http://trac.webkit.org/changeset/86536

Did a quick try and facebook loads correctly, didn't read the patch neither tested further so I can't say anything about the risk.

[Ademar Reis]

(In reply to comment #2)
> This file was last changed 3 days before 2.2 was branched, and this change removed the assert (among many other things) 11 days after the branch.
> http://trac.webkit.org/changeset/86536
> 
> Did a quick try and facebook loads correctly, didn't read the patch neither tested further so I can't say anything about the risk.

It cherry-picks cleanly and in my desktop the tests are fine. I'll push it to the branch and see if the bots complain of something.

[Ademar Reis]

I cherry-picked r86536 and the bots are happy. I guess we're OK with it. If someone complains in the next weeks I'll revisit this bug. Thanks!