RESOLVED FIXED 65762
Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible 
https://bugs.webkit.org/show_bug.cgi?id=65762
Summary Introduced fast path for border rendering when all visible sides are solid, s...
Ben Wells
Reported 2011-08-05 03:24:49 PDT
Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
Attachments
Patch (7.49 KB, patch)
2011-08-05 03:32 PDT, Ben Wells 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Wells
Comment 1 2011-08-05 03:31:32 PDT
In a development version of gmail we have noticed some performance problems with table cells with rgba borders on one side only. The performance degradation appeared with the change for 63174, which fixed a bug with alpha borders where they are not all visible by taking this drawing off the optimized path. This change introduces a new optimized path for this case.
Ben Wells
Comment 2 2011-08-05 03:32:40 PDT
Created attachment 103056 [details] Patch
Ben Wells
Comment 3 2011-08-05 03:36:00 PDT
Comment on attachment 103056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103056&action=review > Source/WebCore/rendering/RenderBoxModelObject.cpp:-1491 > - paintBorderSides(graphicsContext, style, outerBorder, innerBorder, edges, AllBorderEdges, bleedAvoidance, includeLogicalLeftEdge, includeLogicalRightEdge, antialias); Note this function is still called later on, without clipping, in the cases where it was used to be called here (!outerBorder.isRounded and !haveAlphaColor)
WebKit Review Bot
Comment 4 2011-08-05 17:16:06 PDT
Comment on attachment 103056 [details] Patch Clearing flags on attachment: 103056 Committed r92529: <http://trac.webkit.org/changeset/92529>
WebKit Review Bot
Comment 5 2011-08-05 17:16:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.