Bug 65759 - Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
Summary: Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-05 01:54 PDT by Adam Barth
Modified: 2011-08-22 11:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (26.07 KB, patch)
2011-08-05 01:56 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-08-05 01:54:07 PDT 
Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
Comment 1 Adam Barth 2011-08-05 01:56:37 PDT 
Created attachment 103052 [details]
Patch
Comment 2 Adam Barth 2011-08-05 11:50:40 PDT 
Comment on attachment 103052 [details]
Patch

Clearing flags on attachment: 103052

Committed r92493: <http://trac.webkit.org/changeset/92493>
Comment 3 Adam Barth 2011-08-05 11:50:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Balazs Kelemen 2011-08-05 14:09:53 PDT 
It broke the main Qt Release bot:
ERROR: test_rebaseline_test (webkitpy.tool.commands.rebaseline_unittest.TestRebaseline)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 48, in test_rebaseline_test
    OutputCapture().assert_outputs(self, command._rebaseline_test, ["Webkit Linux", "userscripts/another-test.html", "txt"], expected_stdout=expected_stdout)
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 63, in assert_outputs
    return_value = function(*args, **kwargs)
  File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 109, in _rebaseline_test
    self._save_baseline(self._tool.web.get_binary(source_baseline, convert_404_to_None=True), target_baseline)
TypeError: get_binary() got an unexpected keyword argument 'convert_404_to_None'

Have you got an idea about what's going on here?
Comment 5 Dimitri Glazkov (Google) 2011-08-05 14:38:53 PDT 
(In reply to comment #4)
> It broke the main Qt Release bot:
> ERROR: test_rebaseline_test (webkitpy.tool.commands.rebaseline_unittest.TestRebaseline)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 48, in test_rebaseline_test
>     OutputCapture().assert_outputs(self, command._rebaseline_test, ["Webkit Linux", "userscripts/another-test.html", "txt"], expected_stdout=expected_stdout)
>   File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 63, in assert_outputs
>     return_value = function(*args, **kwargs)
>   File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 109, in _rebaseline_test
>     self._save_baseline(self._tool.web.get_binary(source_baseline, convert_404_to_None=True), target_baseline)
> TypeError: get_binary() got an unexpected keyword argument 'convert_404_to_None'
> 
> Have you got an idea about what's going on here?

Breakage fixed in http://trac.webkit.org/changeset/92515.
Comment 6 James Robinson 2011-08-22 11:30:24 PDT 
This patch commented out the chromium gpu linux bot without any obvious explanation.  webkit-patch rebaseline-expectations does not seem to work at all for linux gpu tests now.
Comment 7 Adam Barth 2011-08-22 11:42:12 PDT 
> This patch commented out the chromium gpu linux bot without any obvious explanation.  webkit-patch rebaseline-expectations does not seem to work at all for linux gpu tests now.

Yeah, I'm not entirely sure what's going on here.  dglazkov said something about those bots being virtual or something.  I've filed Bug 66694.  I'll take a look once I've made some progress on the stability Code Yellow.