Bug 65748 - Remove LegacyDefaultOptionalArguments flag from inspector IDLs
Summary: Remove LegacyDefaultOptionalArguments flag from inspector IDLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-04 22:20 PDT by Mark Pilgrim (Google)
Modified: 2011-10-28 12:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.71 KB, patch)
2011-08-04 22:21 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (2.28 KB, patch)
2011-10-28 11:27 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-08-04 22:20:20 PDT
As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates all remaining inspector-related IDL files. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa.

All existing tests pass.
Comment 1 Mark Pilgrim (Google) 2011-08-04 22:21:00 PDT
Created attachment 103037 [details]
Patch
Comment 2 Adam Barth 2011-08-04 22:38:05 PDT
Comment on attachment 103037 [details]
Patch

These IDLs are only used internally by the Web Inspector.  We shouldn't have any compat hacks in them.  If making them strict breaks the inspector, then we should fix the inspector.
Comment 3 Erik Arvidsson 2011-10-28 11:27:27 PDT
Created attachment 112884 [details]
Patch
Comment 4 Erik Arvidsson 2011-10-28 11:28:10 PDT
I manually checked all usages of the functions in these IDL files.
Comment 5 Adam Barth 2011-10-28 11:28:43 PDT
+pfeldman Please let us know if this causes any problems for the inspector.
Comment 6 Adam Barth 2011-10-28 11:28:59 PDT
> I manually checked all usages of the functions in these IDL files.

Great!
Comment 7 WebKit Review Bot 2011-10-28 12:29:15 PDT
Comment on attachment 112884 [details]
Patch

Clearing flags on attachment: 112884

Committed r98750: <http://trac.webkit.org/changeset/98750>
Comment 8 WebKit Review Bot 2011-10-28 12:29:20 PDT
All reviewed patches have been landed.  Closing bug.