RESOLVED FIXED 65748
Remove LegacyDefaultOptionalArguments flag from inspector IDLs 
https://bugs.webkit.org/show_bug.cgi?id=65748
Summary Remove LegacyDefaultOptionalArguments flag from inspector IDLs
Mark Pilgrim (Google)
Reported 2011-08-04 22:20:20 PDT
As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates all remaining inspector-related IDL files. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa. All existing tests pass.
Attachments
Patch (4.71 KB, patch)
2011-08-04 22:21 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (2.28 KB, patch)
2011-10-28 11:27 PDT, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-08-04 22:21:00 PDT
Created attachment 103037 [details] Patch
Adam Barth
Comment 2 2011-08-04 22:38:05 PDT
Comment on attachment 103037 [details] Patch These IDLs are only used internally by the Web Inspector. We shouldn't have any compat hacks in them. If making them strict breaks the inspector, then we should fix the inspector.
Erik Arvidsson
Comment 3 2011-10-28 11:27:27 PDT
Created attachment 112884 [details] Patch
Erik Arvidsson
Comment 4 2011-10-28 11:28:10 PDT
I manually checked all usages of the functions in these IDL files.
Adam Barth
Comment 5 2011-10-28 11:28:43 PDT
+pfeldman Please let us know if this causes any problems for the inspector.
Adam Barth
Comment 6 2011-10-28 11:28:59 PDT
> I manually checked all usages of the functions in these IDL files. Great!
WebKit Review Bot
Comment 7 2011-10-28 12:29:15 PDT
Comment on attachment 112884 [details] Patch Clearing flags on attachment: 112884 Committed r98750: <http://trac.webkit.org/changeset/98750>
WebKit Review Bot
Comment 8 2011-10-28 12:29:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.