As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates Document.idl. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa. All existing tests pass.
Created attachment 102979 [details] Patch
Comment on attachment 102979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102979&action=review > Source/WebCore/dom/Document.idl:46 > - [ReturnsNew] EntityReference createEntityReference(in DOMString name) > + [ReturnsNew] EntityReference createEntityReference(in [Optional=CallWithDefaultValue] DOMString name) Crazy. I have no idea what ReturnsNew means. > Source/WebCore/dom/Document.idl:332 > + [ReturnsNew, EnabledAtRuntime] Touch createTouch(in [Optional=CallWithDefaultValue] DOMWindow window, > + in [Optional=CallWithDefaultValue] EventTarget target, > + in [Optional=CallWithDefaultValue] long identifier, > + in [Optional=CallWithDefaultValue] long pageX, > + in [Optional=CallWithDefaultValue] long pageY, > + in [Optional=CallWithDefaultValue] long screenX, > + in [Optional=CallWithDefaultValue] long screenY, > + in [Optional=CallWithDefaultValue] long webkitRadiusX, > + in [Optional=CallWithDefaultValue] long webkitRadiusY, > + in [Optional=CallWithDefaultValue] float webkitRotationAngle, > + in [Optional=CallWithDefaultValue] float webkitForce) This API seems poorly designed, but that's another story. What does it mean to have prefixed argument names?
(In reply to comment #2) > (From update of attachment 102979 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102979&action=review > > > Source/WebCore/dom/Document.idl:46 > > - [ReturnsNew] EntityReference createEntityReference(in DOMString name) > > + [ReturnsNew] EntityReference createEntityReference(in [Optional=CallWithDefaultValue] DOMString name) > > Crazy. I have no idea what ReturnsNew means. In NativeToJSValue, it adds an extra ", true" parameter when calling toV8(). No idea what that does though.
Comment on attachment 102979 [details] Patch Clearing flags on attachment: 102979 Committed r92436: <http://trac.webkit.org/changeset/92436>
All reviewed patches have been landed. Closing bug.