Update the contributors page to recommend webkit-patch instead of many manual steps
Created attachment 102967 [details] Patch
Comment on attachment 102967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102967&action=review > Websites/webkit.org/coding/contributing.html:125 > +<p>The easiest way to create a patch is to run > +<code>Tools/Scripts/webkit-patch upload</code>. This will upload your current > +Subversion diff (or Git diff if you Should we say that you can supply the bug number if the bug already exists? > Websites/webkit.org/coding/contributing.html:137 > +<p>The "No new tests. (OOPS!)" line appears if <code>prepare-ChangeLog</code> did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), you should include a line stating such. Otherwise all changes require test cases which should be mentioned in the ChangeLog.</p> Rather than saying "you should include a line stating such" maybe we should say that you should replace the OOPS line with an explanation, etc. It's a common error to leave in the "No new tests" OOPS line, which prevents the patch from landing.
> Should we say that you can supply the bug number if the bug already exists? webkit-patch prints "Enter title or issue number" or something like that, so I don't think this is necessary. > > > Websites/webkit.org/coding/contributing.html:137 > > +<p>The "No new tests. (OOPS!)" line appears if <code>prepare-ChangeLog</code> did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), you should include a line stating such. Otherwise all changes require test cases which should be mentioned in the ChangeLog.</p> > > Rather than saying "you should include a line stating such" maybe we should say that you should replace the OOPS line with an explanation, etc. It's a common error to leave in the "No new tests" OOPS line, which prevents the patch from landing. Done.
Created attachment 102983 [details] Patch
(In reply to comment #3) > > Should we say that you can supply the bug number if the bug already exists? > > webkit-patch prints "Enter title or issue number" or something like that, so I don't think this is necessary. Oh, I totally forgot about that feature.
Comment on attachment 102983 [details] Patch Ok. I'll be on the lookout for new contributors having trouble with webkit-patch. Thanks for updating the docs.
Comment on attachment 102983 [details] Patch Clearing flags on attachment: 102983 Committed r92421: <http://trac.webkit.org/changeset/92421>
All reviewed patches have been landed. Closing bug.