Bug 65712 - REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later.
Summary: REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operatio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-08-04 12:53 PDT by Brady Eidson
Modified: 2011-08-04 13:14 PDT (History)
0 users

See Also:


Attachments
Patch v1 - Set a bool before it's value will be needed, not after. (1.69 KB, patch)
2011-08-04 12:56 PDT, Brady Eidson
darin: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-08-04 12:53:14 PDT
REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later.

This is as simple as a bool that's not set correctly before some potentially-thread-launching-operations begin.

Patch coming.

In radar as <rdar://problem/9882581> and <rdar://problem/8186793>
Comment 1 Brady Eidson 2011-08-04 12:54:08 PDT
(In reply to comment #0)
> In radar as <rdar://problem/9882581> and <rdar://problem/8186793>

That's actually 9868015 instead of 8186793
Comment 2 Brady Eidson 2011-08-04 12:56:22 PDT
Created attachment 102962 [details]
Patch v1 - Set a bool before it's value will be needed, not after.
Comment 3 Darin Adler 2011-08-04 12:57:29 PDT
Comment on attachment 102962 [details]
Patch v1 - Set a bool before it's value will be needed, not after.

Any way to do a regression test on this?
Comment 4 Brady Eidson 2011-08-04 13:14:01 PDT
(In reply to comment #3)
> (From update of attachment 102962 [details])
> Any way to do a regression test on this?

AFAIK it was seen precisely once in one of the local storage tests since I originally landed, so one could argue it's already "covered"

That said, it's been quite elusive to reproduce even testing under the browser.  It's only been seen a handful of times there.  Very racy.

I'm open to ideas but don't think it's worth holding up landing.
Comment 5 Brady Eidson 2011-08-04 13:14:50 PDT
Landed in r92406