Bug 65701 - Web Inspector: auto-completion for string literals doesn't work
Summary: Web Inspector: auto-completion for string literals doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-04 10:20 PDT by anton muhin
Modified: 2011-08-10 07:37 PDT (History)
12 users (show)

See Also:

Attachments
Patch (24.73 KB, patch)
2011-08-10 03:03 PDT, Pavel Feldman 		yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2011-08-04 10:20:34 PDT 
In console 'a'. does suggest possible completions.
Comment 1 Pavel Feldman 2011-08-10 03:03:44 PDT 
Created attachment 103459 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-10 03:07:46 PDT 
Attachment 103459 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InjectedScript.cpp:77:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.cpp:398:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.h:107:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:79:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 4 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-08-10 03:29:00 PDT 
Comment on attachment 103459 [details]
Patch

Attachment 103459 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9340519

New failing tests:
inspector/network-status-non-http.html
Comment 4 Yury Semikhatsky 2011-08-10 06:08:20 PDT 
Comment on attachment 103459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103459&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:427
> +            function getCompletions(primitiveType)

This must be left as
 var getCompletions = function...
to avoid cluttering inspected global scope with our named functions.
Comment 5 Pavel Feldman 2011-08-10 07:37:48 PDT 
Committed r92768: <http://trac.webkit.org/changeset/92768>