Bug 65701 – Web Inspector: auto-completion for string literals doesn't work

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[anton muhin]

In console 'a'. does suggest possible completions.

[Pavel Feldman]

Created attachment 103459 [details]
Patch

[WebKit Review Bot]

Attachment 103459 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InjectedScript.cpp:77:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.cpp:398:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.h:107:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:79:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 4 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 103459 [details]
Patch

Attachment 103459 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9340519

New failing tests:
inspector/network-status-non-http.html

[Yury Semikhatsky]

Comment on attachment 103459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103459&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:427
> +            function getCompletions(primitiveType)

This must be left as
 var getCompletions = function...
to avoid cluttering inspected global scope with our named functions.

[Pavel Feldman]

Committed r92768: <http://trac.webkit.org/changeset/92768>