RESOLVED FIXED65682
Web Inspector: Rename sourceId -> scriptId in the protocol and the source code. 
https://bugs.webkit.org/show_bug.cgi?id=65682
Summary Web Inspector: Rename sourceId -> scriptId in the protocol and the source code.
Pavel Feldman
Reported 2011-08-04 05:06:07 PDT
Patch to follow.
Attachments
Patch (56.26 KB, patch)
2011-08-04 05:16 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (56.29 KB, patch)
2011-08-04 05:29 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (47.29 KB, patch)
2011-08-04 06:01 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-08-04 05:16:09 PDT
Created attachment 102897 [details] Patch
WebKit Review Bot
Comment 2 2011-08-04 05:19:58 PDT
Attachment 102897 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 Source/WebCore/inspector/InspectorDebuggerAgent.cpp:184: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.cpp:214: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.cpp:318: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.cpp:318: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:85: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:90: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:90: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 7 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yury Semikhatsky
Comment 3 2011-08-04 05:25:55 PDT
Comment on attachment 102897 [details] Patch Please split this change into two: sourceId->scriptId rename and the breakpoint url regex related change.
Pavel Feldman
Comment 4 2011-08-04 05:29:25 PDT
Created attachment 102899 [details] Patch
WebKit Review Bot
Comment 5 2011-08-04 05:30:42 PDT
Attachment 102899 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 Source/WebCore/inspector/InspectorDebuggerAgent.cpp:184: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.cpp:214: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.cpp:318: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.cpp:318: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:85: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:90: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:90: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 7 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 6 2011-08-04 06:01:06 PDT
Created attachment 102901 [details] Patch
WebKit Review Bot
Comment 7 2011-08-04 06:03:20 PDT
Attachment 102901 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 Source/WebCore/inspector/InspectorDebuggerAgent.cpp:208: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.cpp:312: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.cpp:312: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:90: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:90: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 5 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 8 2011-08-04 06:07:45 PDT
Committed r92369: <http://trac.webkit.org/changeset/92369>
Note You need to log in before you can comment on or make changes to this bug.