Bug 65678 - IndexedDB: Stop using free-lists for database/object store/index ids.
: IndexedDB: Stop using free-lists for database/object store/index ids.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Hans Wennborg
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-04 03:26 PDT by Hans Wennborg
Modified: 2011-08-05 01:43 PDT (History)
2 users (show)

See Also:


Attachments
Patch (9.19 KB, patch)
2011-08-04 03:33 PDT, Hans Wennborg
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2011-08-04 03:26:50 PDT
IndexedDB: Stop using free-lists for database/object store/index ids.
Comment 1 Hans Wennborg 2011-08-04 03:33:37 PDT
Created attachment 102893 [details]
Patch
Comment 2 Hans Wennborg 2011-08-04 03:34:35 PDT
David, would you like to take a look?
Comment 3 David Grogan 2011-08-04 10:02:11 PDT
Comment on attachment 102893 [details]
Patch

LGTM
Comment 4 Hans Wennborg 2011-08-04 10:06:43 PDT
Thanks! Tony, would you like to take a look?
Comment 5 Tony Chang 2011-08-04 10:23:00 PDT
Comment on attachment 102893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102893&action=review

> Source/WebCore/storage/IDBLevelDBBackingStore.cpp:293
> +        return -1;

Do you mean to return false here?
Comment 6 Hans Wennborg 2011-08-05 01:16:05 PDT
(In reply to comment #5)
> (From update of attachment 102893 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102893&action=review
> 
> > Source/WebCore/storage/IDBLevelDBBackingStore.cpp:293
> > +        return -1;
> 
> Do you mean to return false here?
Yes, of course. Good catch!

Thanks for the review!
Comment 7 Hans Wennborg 2011-08-05 01:43:14 PDT
Committed r92468: <http://trac.webkit.org/changeset/92468>