Bug 65678 - IndexedDB: Stop using free-lists for database/object store/index ids.
: IndexedDB: Stop using free-lists for database/object store/index ids.
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-08-04 03:26 PST by
Modified: 2011-08-05 01:43 PST (History)


Attachments
Patch (9.19 KB, patch)
2011-08-04 03:33 PST, Hans Wennborg
tony: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-08-04 03:26:50 PST
IndexedDB: Stop using free-lists for database/object store/index ids.
------- Comment #1 From 2011-08-04 03:33:37 PST -------
Created an attachment (id=102893) [details]
Patch
------- Comment #2 From 2011-08-04 03:34:35 PST -------
David, would you like to take a look?
------- Comment #3 From 2011-08-04 10:02:11 PST -------
(From update of attachment 102893 [details])
LGTM
------- Comment #4 From 2011-08-04 10:06:43 PST -------
Thanks! Tony, would you like to take a look?
------- Comment #5 From 2011-08-04 10:23:00 PST -------
(From update of attachment 102893 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=102893&action=review

> Source/WebCore/storage/IDBLevelDBBackingStore.cpp:293
> +        return -1;

Do you mean to return false here?
------- Comment #6 From 2011-08-05 01:16:05 PST -------
(In reply to comment #5)
> (From update of attachment 102893 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102893&action=review
> 
> > Source/WebCore/storage/IDBLevelDBBackingStore.cpp:293
> > +        return -1;
> 
> Do you mean to return false here?
Yes, of course. Good catch!

Thanks for the review!
------- Comment #7 From 2011-08-05 01:43:14 PST -------
Committed r92468: <http://trac.webkit.org/changeset/92468>