Bug 65676 - Move <input type=week> tests to fast/forms/week/
Summary: Move <input type=week> tests to fast/forms/week/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 65915
  Show dependency tree / graph
 
Reported: 2011-08-04 02:54 PDT by Kent Tamura
Modified: 2011-08-09 06:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (212.14 KB, patch)
2011-08-04 02:57 PDT, Kent Tamura 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-08-04 02:54:52 PDT 
Move <input type=week> tests to fast/forms/week/ for ease of disabling the week type.
Comment 1 Kent Tamura 2011-08-04 02:57:46 PDT 
Created attachment 102891 [details]
Patch
Comment 2 Kent Tamura 2011-08-04 03:01:53 PDT 
I'd like to make subdirectories of fast/forms for each of form control types.
 - ease to disable the type
    Type=color is disabled temporarily for UI enhancement
    Use-case of some types are questionable. Such types might be removed from the specification.

 - discoverability
   There are a lot of tests in fast/forms/.
Comment 3 Tony Chang 2011-08-04 09:43:01 PDT 
Comment on attachment 102891 [details]
Patch

Looks like we need to move the following results too:
chromium-mac/fast/forms/ValidityState-typeMismatch-url-expected.txt
chromium-win/fast/forms/ValidityState-typeMismatch-url-expected.txt
qt/fast/forms/date-input-visible-strings-expected.png

Please watch the bots as you land.
Comment 4 Kent Tamura 2011-08-04 16:15:41 PDT 
(In reply to comment #3)

Thank you for r+.

> Looks like we need to move the following results too:
> chromium-mac/fast/forms/ValidityState-typeMismatch-url-expected.txt
> chromium-win/fast/forms/ValidityState-typeMismatch-url-expected.txt

They are for type=url. So they won't be affected.

> qt/fast/forms/date-input-visible-strings-expected.png

It's a stale result. date-input-visible-strings.html was changed to dumpAsText() some months ago.
Comment 5 Kent Tamura 2011-08-04 16:17:53 PDT 
Committed r92427: <http://trac.webkit.org/changeset/92427>
Comment 6 Tony Chang 2011-08-04 16:19:13 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> 
> Thank you for r+.
> 
> > Looks like we need to move the following results too:
> > chromium-mac/fast/forms/ValidityState-typeMismatch-url-expected.txt
> > chromium-win/fast/forms/ValidityState-typeMismatch-url-expected.txt
> 
> They are for type=url. So they won't be affected.
> 
> > qt/fast/forms/date-input-visible-strings-expected.png
> 
> It's a stale result. date-input-visible-strings.html was changed to dumpAsText() some months ago.

Ah, you're right, sorry!  We should probably just delete qt/fast/forms/date-input-visible-strings-expected.png.