Bug 65675 - Eval handling attempts literal parsing even when the eval string is in the cache
Summary: Eval handling attempts literal parsing even when the eval string is in the cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-04 02:35 PDT by Filip Pizlo
Modified: 2011-08-04 10:49 PDT (History)
1 user (show)

See Also:


Attachments
the patch (5.96 KB, patch)
2011-08-04 02:38 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-08-04 02:35:01 PDT
Interpreter::callEval should first check if the string is in the eval code cache, and only attempt literal parsing if it isn't.
Comment 1 Filip Pizlo 2011-08-04 02:38:56 PDT
Created attachment 102890 [details]
the patch

Tests still running.
Comment 2 Filip Pizlo 2011-08-04 02:45:49 PDT
Comment on attachment 102890 [details]
the patch

Tests pass, ready for review.
Comment 3 Oliver Hunt 2011-08-04 09:49:53 PDT
Comment on attachment 102890 [details]
the patch

ouchies
Comment 4 WebKit Review Bot 2011-08-04 10:48:57 PDT
Comment on attachment 102890 [details]
the patch

Clearing flags on attachment: 102890

Committed r92386: <http://trac.webkit.org/changeset/92386>
Comment 5 WebKit Review Bot 2011-08-04 10:49:01 PDT
All reviewed patches have been landed.  Closing bug.